QBzr

Merge lp:~doxxx/qbzr/qinit-default-format into lp:qbzr

  1. qinit-default-format
  2. Merge into trunk2a
Proposed by Gordon Tyler
Status: Merged
Merged at revision: not available
Proposed branch: lp:~doxxx/qbzr/qinit-default-format
Merge into: lp:qbzr
Diff against target: 12 lines (+1/-1)
1 file modified
lib/init.py (+1/-1)
To merge this branch: bzr merge lp:~doxxx/qbzr/qinit-default-format
Reviewer Review Type Date Requested Status
Alexander Belchenko Approve
Review via email: mp+23646@code.launchpad.net

Description of the change

This fixes bug 531795 by fixing the way default_index is set in fill_option_combo.

To post a comment you must log in.
Revision history for this message
Gordon Tyler (doxxx) wrote :

Sorry, forgot to remove debug code.

Revision history for this message
Gordon Tyler (doxxx) wrote :

There we go. That looks better.

Revision history for this message
Alexander Belchenko (bialix) wrote :

Thanks. Next time write some NEWS message, please.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/init.py'
2--- lib/init.py 2010-03-01 20:25:20 +0000
3+++ lib/init.py 2010-04-19 03:56:21 +0000
4@@ -117,7 +117,7 @@
5 user_data = QtCore.QVariant(help or '')
6 combo.addItem(name, user_data)
7 if name == default:
8- default_index = i - 1
9+ default_index = combo.count() - 1
10 if desc_widget is not None:
11 combo.parentWidget().connect(combo,
12 QtCore.SIGNAL("currentIndexChanged(int)"),

Subscribers

People subscribed via source and target branches