Merge lp:~dorian-kemps/unifield-web/UW-5436 into lp:unifield-web

Proposed by jftempo
Status: Merged
Merged at revision: 4962
Proposed branch: lp:~dorian-kemps/unifield-web/UW-5436
Merge into: lp:unifield-web
Diff against target: 86 lines (+25/-5)
3 files modified
addons/openerp/static/javascript/listgrid.js (+14/-3)
addons/openerp/widgets/templates/listgrid/listgrid.mako (+5/-1)
addons/openerp/widgets/templates/listgrid/listgroup.mako (+6/-1)
To merge this branch: bzr merge lp:~dorian-kemps/unifield-web/UW-5436
Reviewer Review Type Date Requested Status
UniField Dev Team Pending
Review via email: mp+366475@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/openerp/static/javascript/listgrid.js'
2--- addons/openerp/static/javascript/listgrid.js 2019-02-13 14:15:09 +0000
3+++ addons/openerp/static/javascript/listgrid.js 2019-04-24 15:18:07 +0000
4@@ -59,6 +59,7 @@
5
6 this.sort_order = null;
7 this.sort_key = null;
8+ this.sort_column = null;
9 },
10
11 get_previously_selected: function() {
12@@ -323,6 +324,12 @@
13 else this.sort_order = 'asc';
14
15 this.sort_key = column;
16+ var field_d = jQuery(field)
17+ if (field_d.attr('sort_column')) {
18+ this.sort_key = field_d.attr('sort_column');
19+ }
20+
21+ this.sort_column = column;
22 if(this.ids.length) {
23 this.reload();
24 }
25@@ -364,6 +371,10 @@
26 if (group_by_context == '[]' && this.sort_order) {
27 sort_order = this.sort_order;
28 sort_key = this.sort_key;
29+ col = jQuery('#grid-data-column/'+sort_key)
30+ if (col && col.attr('sort_column')) {
31+ sort_key = col.attr('sort_column')
32+ }
33 }
34 if (jQuery(group).hasClass('group-expand')) {
35 // get listview selectable value, so we know if we are in
36@@ -1089,12 +1100,12 @@
37
38 MochiKit.Signal.signal(__listview, 'onreload');
39
40- if(self.sort_key != null) {
41+ if(self.sort_column != null) {
42 var $th;
43 if(self.name != '_terp_list') {
44- $th = jQuery(idSelector('grid-data-column/' + self.name + '/' + self.sort_key));
45+ $th = jQuery(idSelector('grid-data-column/' + self.name + '/' + self.sort_column));
46 } else {
47- $th = jQuery(idSelector('grid-data-column/' + self.sort_key));
48+ $th = jQuery(idSelector('grid-data-column/' + self.sort_column));
49 }
50 $th.append(
51 jQuery('<span>&nbsp;</span>')
52
53=== modified file 'addons/openerp/widgets/templates/listgrid/listgrid.mako'
54--- addons/openerp/widgets/templates/listgrid/listgrid.mako 2019-02-10 18:09:25 +0000
55+++ addons/openerp/widgets/templates/listgrid/listgrid.mako 2019-04-24 15:18:07 +0000
56@@ -326,7 +326,11 @@
57 % if (field_attrs.get('function') and not field_attrs.get('store') and not field_attrs.get('allow_sort')) or field_attrs.get('not_sortable'):
58 <th id="grid-data-column/${(name != '_terp_list' or None) and (name + '/')}${field}" class="grid-cell ${field_attrs.get('type', 'char')}" kind="${field_attrs.get('type', 'char')}">${field_attrs['string']|br}</th>
59 % else:
60- <th id="grid-data-column/${(name != '_terp_list' or None) and (name + '/')}${field}" class="grid-cell ${field_attrs.get('type', 'char')}" kind="${field_attrs.get('type', 'char')}" style="cursor: pointer;" onclick="new ListView('${name}').sort_by_order('${field}', this)">${field_attrs['string']|br}</th>
61+ <th id="grid-data-column/${(name != '_terp_list' or None) and (name + '/')}${field}" class="grid-cell ${field_attrs.get('type', 'char')}" kind="${field_attrs.get('type', 'char')}" style="cursor: pointer;" onclick="new ListView('${name}').sort_by_order('${field}', this)"
62+ % if field_attrs.get('sort_column'):
63+ sort_column="${field_attrs.get('sort_column')}"
64+ % endif
65+ >${field_attrs['string']|br}</th>
66 % endif
67 % endif
68 % endfor
69
70=== modified file 'addons/openerp/widgets/templates/listgrid/listgroup.mako'
71--- addons/openerp/widgets/templates/listgrid/listgroup.mako 2019-01-21 14:10:10 +0000
72+++ addons/openerp/widgets/templates/listgrid/listgroup.mako 2019-04-24 15:18:07 +0000
73@@ -47,7 +47,12 @@
74 % if field == 'button':
75 <th class="grid-cell"><div style="width: 0;"></div></th>
76 % elif not field_attrs.get('not_sortable'):
77- <th id="grid-data-column/${(name != '_terp_list' or None) and (name + '/')}${field}" class="grid-cell ${field_attrs.get('type', 'char')}" kind="${field_attrs.get('type', 'char')}" style="cursor: pointer;" onclick="new ListView('${name}').sort_by_order('${field}', this)">${field_attrs['string']}</th>
78+ <th id="grid-data-column/${(name != '_terp_list' or None) and (name + '/')}${field}" class="grid-cell ${field_attrs.get('type', 'char')}" kind="${field_attrs.get('type', 'char')}" style="cursor: pointer;" onclick="new ListView('${name}').sort_by_order('${field}', this)"
79+ % if field_attrs.get('sort_column'):
80+ sort_column="${field_attrs.get('sort_column')}"
81+ % endif
82+
83+ >${field_attrs['string']}</th>
84 %else:
85 <th id="grid-data-column/${(name != '_terp_list' or None) and (name + '/')}${field}" class="grid-cell ${field_attrs.get('type', 'char')}" kind="${field_attrs.get('type', 'char')}">${field_attrs['string']}</th>
86 % endif

Subscribers

People subscribed via source and target branches