linaro-license-protection

Merge lp:~dooferlad/linaro-license-protection/handle-broken-simlinks into lp:~linaro-automation/linaro-license-protection/trunk

  1. handle-broken-simlinks
  2. Merge into trunk
Proposed by James Tunnicliffe
Status: Merged
Approved by: Данило Шеган
Approved revision: 119
Merged at revision: 118
Proposed branch: lp:~dooferlad/linaro-license-protection/handle-broken-simlinks
Merge into: lp:~linaro-automation/linaro-license-protection/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~dooferlad/linaro-license-protection/handle-broken-simlinks
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Review via email: mp+121186@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Nice quick fix, thanks (fwiw, I did want to say how it'd be even better if we created all the sample files inside tests, but now is not the time to bring that up—oh wait, sorry :).

review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

After some more discussion and hearing how it's as easy to still list the broken symlink and return a 404, I'd prefer that solution.

review: Needs Fixing
Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, apart from the new vocabulary ("simlink" :). Still, let's land this, with or without changing that.

review: Approve
lp:~dooferlad/linaro-license-protection/handle-broken-simlinks updated
120. By James Tunnicliffe

Fix spelling errors

121. By James Tunnicliffe

Directory for tests was missing.
Another spelling error.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches