Merge lp:~dooferlad/linaro-android-frontend/proxy_lava-job-info_updates into lp:linaro-android-frontend

Proposed by James Tunnicliffe
Status: Merged
Merged at revision: 243
Proposed branch: lp:~dooferlad/linaro-android-frontend/proxy_lava-job-info_updates
Merge into: lp:linaro-android-frontend
Diff against target: 36 lines (+10/-4)
2 files modified
android_build/frontend/api.py (+6/-2)
static/buildDetails.js (+4/-2)
To merge this branch: bzr merge lp:~dooferlad/linaro-android-frontend/proxy_lava-job-info_updates
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+88095@code.launchpad.net

Description of the change

Fixes problems seen on deployment of last branch.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Looks good.

review: Approve
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Merged, but not deployed, let's do it tomorrow.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'android_build/frontend/api.py'
2--- android_build/frontend/api.py 2012-01-09 18:27:49 +0000
3+++ android_build/frontend/api.py 2012-01-10 18:13:25 +0000
4@@ -276,10 +276,14 @@
5 try:
6 response = urllib2.urlopen(url)
7 except urllib2.HTTPError, e:
8- message = "Server error: {}".format(e.code)
9+ message = "Server error: %d" % e.code
10 return HttpResponse(message)
11 except urllib2.URLError, e:
12- message = "We failed to reach a server. Reason{}".format(e.reason)
13+ message = "We failed to reach a server."
14+
15+ if isinstance(e.reason, str):
16+ message += " Reason %s" % e.reason
17+
18 return HttpResponse(message)
19 else:
20 return HttpResponse(response.read())
21
22=== modified file 'static/buildDetails.js'
23--- static/buildDetails.js 2012-01-10 13:34:52 +0000
24+++ static/buildDetails.js 2012-01-10 18:13:25 +0000
25@@ -102,8 +102,10 @@
26
27 if (typeof receivedLavaJobInfo.got_info != "undefined")
28 {
29-// alert("Two resutls files found. Please report this error by submitting a bug report against" +
30-// " https://code.launchpad.net/~linaro-infrastructure/linaro-android-frontend/trunk")
31+ // Don't pass through a second job info. Assumption is that they are the same
32+ // so it doesn't matter if we find several and they are just duplicates. This
33+ // happened around 12-2011 when we started to migrate build outputs to
34+ // snapshots.linaro.org.
35 return;
36 }
37

Subscribers

People subscribed via source and target branches