Merge lp:~dooferlad/linaro-android-build-tools/add_ext_tarball into lp:linaro-android-build-tools
Proposed by
James Tunnicliffe
Status: | Merged |
---|---|
Merged at revision: | 401 |
Proposed branch: | lp:~dooferlad/linaro-android-build-tools/add_ext_tarball |
Merge into: | lp:linaro-android-build-tools |
Diff against target: |
57 lines (+39/-0) 2 files modified
build-scripts/build-android (+4/-0) build-scripts/helpers (+35/-0) |
To merge this branch: | bzr merge lp:~dooferlad/linaro-android-build-tools/add_ext_tarball |
Related bugs: | |
Related blueprints: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Sokolovsky | Approve | ||
Review via email:
|
Description of the change
A list of external tarballs specified by the $EXTERNAL_TARBALL environment variable are unpacked into $BUILD_
To post a comment you must log in.
This looks nice. Some comments (not worth fixing as such): I try to avoid using pushd in scripts as produces (apparently not suppressible) output which looks strange in bigger context. Also, there is get_url_basename() function, might make sense to use it.
One bigger point which I raised right when request for this feature was made - how would you use contents of such tarball in a build? Its full path would be different for each build, so you couldn't have nice static path to specify in build config for example. The BP should be recording my proposal of making a symlink /tmp/<tarball_ basename> -> /mnt/jenkins/ workspace/ <build name>/build/ external_ tarballs/ <tarball_ basename> to facilitate this.