Merge lp:~donadigo/switchboard/fix-duplicated-plug-navigation into lp:~elementary-pantheon/switchboard/switchboard

[Adam Bieńkowski]

* Fix bug #1593738: "Duplicated plug navigation".

Fixes bug #1593738: "Duplicated plug navigation".

A simple check if the plug is not the same as last time will fix the navigation button glitch.

[Felipe Escoto (philip.scott)]

This should simplify the code since an OR will stop if the first one is true :)

previous_plugs.size == 0 || previous_plugs.@get (0) != plug

review: Needs Fixing

[Felipe Escoto (philip.scott)]

review: Abstain

[RabbitBot (rabbitbot-a)]

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

[Felipe Escoto (philip.scott)]

Woops, i think i presses Abstain instead of Approve

review: Approve

=== modified file 'src/Switchboard.vala'
--- src/Switchboard.vala	2016-06-15 15:10:18 +0000
+++ src/Switchboard.vala	2016-06-18 18:58:00 +0000
@@ -204,7 +204,10 @@
                     return false;
                 });
 
-                previous_plugs.add (plug);
+                if (previous_plugs.size == 0 || previous_plugs.@get (0) != plug) {
+                    previous_plugs.add (plug);
+                }
+
                 // Launch plug's executable
                 navigation_button.set_sensitive (true);
                 navigation_button.set_text (all_settings_label);