Merge lp:~donadigo/switchboard-plug-parental-controls/debian-packaging-fixes into lp:~elementary-pantheon/switchboard-plug-parental-controls/trunk

Proposed by Adam Bieńkowski
Status: Merged
Approved by: Cody Garver
Approved revision: 230
Merged at revision: 229
Proposed branch: lp:~donadigo/switchboard-plug-parental-controls/debian-packaging-fixes
Merge into: lp:~elementary-pantheon/switchboard-plug-parental-controls/trunk
Diff against target: 88 lines (+15/-12)
6 files modified
data/CMakeLists.txt (+1/-9)
data/pantheon-parental-controls-client.desktop (+5/-1)
debian/control (+1/-0)
debian/install (+0/-1)
debian/rules (+7/-1)
debian/switchboard-plug-parental-controls.links (+1/-0)
To merge this branch: bzr merge lp:~donadigo/switchboard-plug-parental-controls/debian-packaging-fixes
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+305349@code.launchpad.net

Commit message

* Fix client desktop entries
* Use dh_systemd

Description of the change

This branch fixes debian packaging to not ask for root permissions for building this package. It also fixes some entries in client desktop file and makes use of native dh_systemd to start / enable systemd service.

To post a comment you must log in.
229. By Adam Bieńkowski

Add missing install changes

230. By Adam Bieńkowski

Add missing links file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/CMakeLists.txt'
2--- data/CMakeLists.txt 2016-05-17 13:51:36 +0000
3+++ data/CMakeLists.txt 2016-09-09 15:00:40 +0000
4@@ -1,15 +1,7 @@
5 configure_file (org.pantheon.switchboard.parental-controls.policy.cmake ${CMAKE_CURRENT_BINARY_DIR}/data/org.pantheon.switchboard.parental-controls.policy)
6-configure_file (pantheon-parental-controls.service.cmake ${CMAKE_CURRENT_BINARY_DIR}/pantheon-parental-controls.service)
7 configure_file (org.pantheon.ParentalControls.service.cmake ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.ParentalControls.service)
8
9 install (FILES ${CMAKE_CURRENT_BINARY_DIR}/data/org.pantheon.switchboard.parental-controls.policy DESTINATION ${CMAKE_INSTALL_FULL_DATAROOTDIR}/polkit-1/actions/)
10 install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.ParentalControls.service DESTINATION share/dbus-1/system-services)
11-install (FILES ${CMAKE_CURRENT_BINARY_DIR}/pantheon-parental-controls.service DESTINATION /lib/systemd/system)
12 install (FILES org.pantheon.ParentalControls.conf DESTINATION /etc/dbus-1/system.d)
13-install (FILES pantheon-parental-controls-client.desktop DESTINATION share/applications)
14-
15-if (ENABLE_DAEMON_STARTUP)
16- set (TARGET_NAME "${CMAKE_CURRENT_BINARY_DIR}/pantheon-parental-controls.service")
17- set (DESTINATION_PATH "/etc/systemd/system/multi-user.target.wants/")
18- execute_process(COMMAND sudo ln -sf ${TARGET_NAME} ${DESTINATION_PATH})
19-ENDIF ()
20\ No newline at end of file
21+install (FILES pantheon-parental-controls-client.desktop DESTINATION share/applications)
22\ No newline at end of file
23
24=== modified file 'data/pantheon-parental-controls-client.desktop'
25--- data/pantheon-parental-controls-client.desktop 2016-08-03 20:28:47 +0000
26+++ data/pantheon-parental-controls-client.desktop 2016-09-09 15:00:40 +0000
27@@ -1,6 +1,10 @@
28 [Desktop Entry]
29 Name=Parental Controls Client
30 Exec=pantheon-parental-controls-client
31+Comment=Show parental control restrictions
32 Icon=preferences-system-parental-controls
33-Comment=Show parental control restrictions
34+Terminal=false
35+Type=Application
36 NoDisplay=true
37+X-GNOME-AutoRestart=true
38+X-GNOME-Autostart-Phase=Applications
39\ No newline at end of file
40
41=== modified file 'debian/control'
42--- debian/control 2015-09-12 02:13:05 +0000
43+++ debian/control 2016-09-09 15:00:40 +0000
44@@ -4,6 +4,7 @@
45 Maintainer: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
46 Build-Depends: cmake,
47 debhelper (>= 9),
48+ dh-systemd (>= 1.5),
49 libaccountsservice-dev,
50 libgranite-dev,
51 libglib2.0-dev,
52
53=== modified file 'debian/install'
54--- debian/install 2016-02-25 20:32:14 +0000
55+++ debian/install 2016-09-09 15:00:40 +0000
56@@ -1,5 +1,4 @@
57 etc/
58-lib/systemd/system
59 usr/bin
60 usr/lib
61 usr/share
62
63=== renamed file 'data/pantheon-parental-controls.service.cmake' => 'debian/pantheon-parental-controls.service'
64=== modified file 'debian/rules'
65--- debian/rules 2015-09-12 02:03:23 +0000
66+++ debian/rules 2016-09-09 15:00:40 +0000
67@@ -10,7 +10,13 @@
68 #export DH_VERBOSE=1
69
70 %:
71- dh $@
72+ dh $@ --with systemd
73+
74+override_dh_systemd_enable:
75+ dh_systemd_enable -ppantheon-parental-controls
76+
77+override_dh_systemd_start:
78+ dh_systemd_start -ppantheon-parental-controls
79
80 override_dh_strip:
81 dh_strip --dbg-package=switchboard-plug-parental-controls-dbg
82
83=== added file 'debian/switchboard-plug-parental-controls.links'
84--- debian/switchboard-plug-parental-controls.links 1970-01-01 00:00:00 +0000
85+++ debian/switchboard-plug-parental-controls.links 2016-09-09 15:00:40 +0000
86@@ -0,0 +1,1 @@
87+/usr/share/applications/pantheon-parental-controls-client.desktop /etc/xdg/autostart/pantheon-parental-controls-client.desktop
88\ No newline at end of file

Subscribers

People subscribed via source and target branches

to all changes: