Code review comment for lp:~donadigo/switchboard-plug-pantheon-shell/fix-wallpaper-permissions

Revision history for this message
Danielle Foré (danrabbit) wrote :

I don't think using a symlink is a good idea. Now you're giving me something to remember: not to delete that wallpaper that's in a random location on my file system. Or worse, it could be on an external drive and now I can't unmount that drive without losing my wallpaper. Copying ensures that the wallpaper won't be removed accidentally.

I do think we should change the permissions without asking. It's a wallpaper, I think it'll be okay. Users expect this feature to work and I don't think we should have to bother less experienced users knowing what permissions even are and why they're needed for this feature.

review: Needs Fixing

« Back to merge proposal