Merge lp:~donadigo/switchboard-plug-notifications/dim-items-label into lp:~elementary-pantheon/switchboard-plug-notifications/trunk

Proposed by Adam Bieńkowski
Status: Needs review
Proposed branch: lp:~donadigo/switchboard-plug-notifications/dim-items-label
Merge into: lp:~elementary-pantheon/switchboard-plug-notifications/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
src/Widgets/AppEntry.vala (+1/-0)
To merge this branch: bzr merge lp:~donadigo/switchboard-plug-notifications/dim-items-label
Reviewer Review Type Date Requested Status
Zisu Andrei (community) Needs Information
elementary Pantheon team Pending
Review via email: mp+303934@code.launchpad.net

Commit message

* Dim items label

Description of the change

Dim the items label.

To post a comment you must log in.
Revision history for this message
Zisu Andrei (matzipan) wrote :

Is this approved? If so, we need to make this unitary over switchboard plugs, like Networking, etc.

review: Needs Information
Revision history for this message
Zisu Andrei (matzipan) wrote :

I just saw your other branch.

Revision history for this message
Zisu Andrei (matzipan) wrote :

While we're at it, maybe we should make Sharing, Online Accounts, User Accounts, Parental Control and Universal Access look the same. The marins and sizes seem to be varying quite wildly.

Unmerged revisions

194. By Adam Bieńkowski

Dim items label

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/AppEntry.vala'
2--- src/Widgets/AppEntry.vala 2016-01-11 18:57:00 +0000
3+++ src/Widgets/AppEntry.vala 2016-08-25 13:34:58 +0000
4@@ -52,6 +52,7 @@
5 title_label.valign = Gtk.Align.END;
6
7 description_label = new Gtk.Label (get_permissions_string (app));
8+ description_label.get_style_context ().add_class (Gtk.STYLE_CLASS_DIM_LABEL);
9 description_label.use_markup = true;
10 description_label.ellipsize = Pango.EllipsizeMode.END;
11 ((Gtk.Misc) description_label).xalign = 0;

Subscribers

People subscribed via source and target branches

to all changes: