Merge lp:~donadigo/switchboard-plug-networking/wifi-connected-on-top into lp:~elementary-pantheon/switchboard-plug-networking/trunk
Proposed by
Adam Bieńkowski
Status: | Rejected |
---|---|
Rejected by: | Adam Bieńkowski |
Proposed branch: | lp:~donadigo/switchboard-plug-networking/wifi-connected-on-top |
Merge into: | lp:~elementary-pantheon/switchboard-plug-networking/trunk |
Diff against target: |
271 lines (+111/-31) 5 files modified
src/Utils.vala (+2/-2) src/Widgets/Page.vala (+1/-1) src/Widgets/WifiInterface.vala (+80/-18) src/common/Widgets/AbstractWifiInterface.vala (+2/-1) src/common/Widgets/WifiMenuItem.vala (+26/-9) |
To merge this branch: | bzr merge lp:~donadigo/switchboard-plug-networking/wifi-connected-on-top |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Bieńkowski (community) | Abstain | ||
Danielle Foré | ux | Approve | |
xapantu | code | Pending | |
Review via email: mp+267189@code.launchpad.net |
Commit message
* Fixes bug #1449669.
* Clean the code.
Description of the change
Fixes bug #1449669. Show the currently connected network at the top in SSID list, and some codestyle fixes. The branch can contain bugs so please point them out in the review if any.
To post a comment you must log in.
Can we set "homogeneous" to true for the button box ;D
Also, can we get the spinner when connecting?
Other than those two things, I like it a lot! It looks nice. Nice animation. Buttons are more in-context. Good job :)