Code review comment for lp:~donadigo/pantheon-files/filechooser-module

Revision history for this message
Daniel Fore (danrabbit) wrote :

It looks like the "back" button doesn't actually go back. It goes "up". Open the dialog, notice that "back" is immediately sensitive. This shouldn't be the case as there is no navigation history. This should either be made into an actual back button (as in Files) or removed since the "up" functionality is already provided in the breadcrumb.

There seems to be a Gtk.ActionBar called "extra_and_filters" above the dialog action box. Is this actionbar necessary? Can it be removed? It causes a weird white area and double border in the open file dialog.

It seems that the new folder item should be present in the Save File dialog and not the Open Folder dialog.

review: Needs Fixing

« Back to merge proposal