Merge lp:~donadigo/gala/fix-mouse-input-freeze into lp:gala

[Adam Bieńkowski]

- Fix bug #1582809: "Clicking a notification freezes mouse input".

Fixes bug #1582809: "Clicking a notification freezes mouse input".

From the documentation of freeze_track property:

Set this property to true *while animating* an actor if you have tracked
actors to prevent constant recalculations (...)

I removed the animation counter and now freeze_track will be true when the animation of notification is happening (either appearing or sliding off).

I've also moved the entry completed connection to where all connections are happening.

[lp:~donadigo/gala/fix-mouse-input-freeze]

530. By Adam Bieńkowski on 2016-07-28

notify: freeze track of notifications area only when a notification animation is happening

=== modified file 'plugins/notify/NotificationStack.vala'
--- plugins/notify/NotificationStack.vala	2014-08-11 18:47:41 +0000
+++ plugins/notify/NotificationStack.vala	2016-07-28 22:19:37 +0000
@@ -31,8 +31,6 @@
 
 		public Screen screen { get; construct; }
 
-		int animation_counter = 0;
-
 		public NotificationStack (Screen screen)
 		{
 			Object (screen: screen);
@@ -46,8 +44,7 @@
 
 		public void show_notification (Notification notification)
 		{
-			if (animation_counter == 0)
-				animations_changed (true);
+			animations_changed (true);
 
 			// raise ourselves when we got something to show
 			get_parent ().set_child_above_sibling (this, null);
@@ -56,23 +53,25 @@
 			// unless we make our container a bit wider and move the notifications over
 			notification.margin_left = ADDITIONAL_MARGIN;
 
+			notification.notify["being-destroyed"].connect (() => {
+				animations_changed (true);
+			});
+
 			notification.destroy.connect (() => {
+				animations_changed (false);
 				update_positions ();
 			});
 
+			notification.get_transition ("entry").completed.connect (() => {
+				animations_changed (false);
+			});
+
 			float height;
 			notification.get_preferred_height (Notification.WIDTH, out height, null);
 			update_positions (height);
 
 			notification.y = TOP_OFFSET;
 			insert_child_at_index (notification, 0);
-
-			animation_counter++;
-
-			notification.get_transition ("entry").completed.connect (() => {
-				if (--animation_counter == 0)
-					animations_changed (false);
-			});
 		}
 
 		void update_positions (float add_y = 0.0f)