Merge lp:~donadigo/appcenter/screenshots-pixbuf into lp:~elementary-apps/appcenter/appcenter

[Adam Bieńkowski]

* Use pixbuf instead FileIcon for screenshots.
* Add separator between header_grid and main content.

This branch changes the screenshots handling from GLib.FileIcon to Gdk.Pixbuf and scales them down to 800x600px with keeping the aspect ratio. In addition I added a separator after header_grid to easily distinguish view elements.

[Danielle Foré (danrabbit)]

This works for me. Definitely makes the screeshots a lot better.

Can you remove that 6px row spacing on the grid that has the sep in it? I agree the sep helps break those boxes up, but it's weird to have that chunk of white between it and the scrollbox.

I also think that we should change the stack so that the preview image expects to take up that 800x600 space instead of the 512. I think we should still seek to reduce text movement here so that we're not interrupting reading when the screenshot loads.

[lp:~donadigo/appcenter/screenshots-pixbuf]

229. By Adam Bieńkowski on 2016-07-01

Use Gdk.Pixbuf for screenshot handling

[Adam Bieńkowski (donadigo)]

Updated.

=== modified file 'src/Views/AppInfoView.vala'
--- src/Views/AppInfoView.vala	2016-06-28 22:48:28 +0000
+++ src/Views/AppInfoView.vala	2016-07-01 12:04:06 +0000
@@ -111,7 +111,6 @@
 
     construct {
         column_spacing = 12;
-        row_spacing = 6;
 
         app_icon = new Gtk.Image ();
         app_icon.margin_top = 12;
@@ -119,7 +118,8 @@
         app_icon.pixel_size = 128;
 
         app_screenshot = new Gtk.Image ();
-        app_screenshot.pixel_size = 512;
+        app_screenshot.width_request = 800;
+        app_screenshot.height_request = 600;
         app_screenshot.icon_name = "image-x-generic";
         app_screenshot.halign = Gtk.Align.CENTER;
 
@@ -234,7 +234,8 @@
         header_grid.attach (app_summary, 1, 1, 3, 1);
 
         attach (header_grid, 0, 0, 1, 1);
-        attach (scrolled, 0, 1, 1, 1);
+        attach (new Gtk.Separator (Gtk.Orientation.HORIZONTAL), 0, 1, 1, 1);
+        attach (scrolled, 0, 2, 1, 1);
     }
 
     private async void load_extensions () {
@@ -365,10 +366,14 @@
             }
         }
 
-        var icon = new FileIcon (fileimage);
         Idle.add (() => {
-            app_screenshot.gicon = icon;
-            screenshot_stack.visible_child = app_screenshot;
+            try {
+                app_screenshot.pixbuf = new Gdk.Pixbuf.from_file_at_scale (fileimage.get_path (), 800, 600, true);
+                screenshot_stack.visible_child = app_screenshot;
+            } catch (Error e) {
+                critical (e.message);
+            }
+        
             return GLib.Source.REMOVE;
         });
     }