Merge lp:~donadigo/appcenter/main-window-cache into lp:~elementary-apps/appcenter/appcenter

[Adam Bieńkowski]

* Cache main window once to show it immediately to the user

This branch does some changes to how the main window is handeled / shown. Since appcenter is always running, the main window can be cached and kept in the memory while in trunk it gets destroyed and rebuilt again when user wants to open it.

With this branch there should be a noticeable speed increase when opening the window.

Keep in mind that this branch is *experimental*, it increases memory use in the system and should be heavily tested before merging it.

[lp:~donadigo/appcenter/main-window-cache]

376. By Adam Bieńkowski on 2017-01-15

Don't get the client explicitly on activate

[Danielle Foré (danrabbit)]

This kind of seems like a not great idea to me. I don't think there's a need to prioritize launching appcenter faster. It already launches fast. I think the fact that we don't hold onto that memory in the background is a feature

Unmerged revisions

376. By Adam Bieńkowski on 2017-01-15

Don't get the client explicitly on activate

375. By Adam Bieńkowski on 2017-01-15

Some experimental improvements to how main window is handeled

=== modified file 'src/Application.vala'
--- src/Application.vala	2016-12-28 16:29:00 +0000
+++ src/Application.vala	2017-01-15 14:50:52 +0000
@@ -94,35 +94,34 @@
         activate ();
     }
 
+    public override void startup () {
+        base.startup ();
+
+        main_window = new MainWindow (this);
+        add_window (main_window);
+
+        var client = AppCenterCore.Client.get_default ();
+        client.update_cache.begin (true);
+    }
+
     public override void activate () {
-        var client = AppCenterCore.Client.get_default ();
         if (silent) {
             NetworkMonitor.get_default ().network_changed.connect ((available) => {
                 schedule_cache_update (!available);
             });
 
-            client.update_cache.begin (true);
             silent = false;
             hold ();
             return;
         }
 
-        if (main_window == null) {
-            client.update_cache.begin (true);
-
-            main_window = new MainWindow (this);
-            main_window.destroy.connect (() => {
-                main_window = null;
-            });
-
-            add_window (main_window);
-            main_window.show_all ();
-            if (show_updates) {
-                main_window.go_to_installed ();
-            }
+        main_window.show_all ();
+        if (show_updates) {
+            main_window.go_to_installed ();
         }
 
         if (link != null) {
+            var client = AppCenterCore.Client.get_default ();
             var package = client.get_package_for_id (link);
             if (package != null) {
                 main_window.show_package (package);

=== modified file 'src/MainWindow.vala'
--- src/MainWindow.vala	2016-12-27 23:21:25 +0000
+++ src/MainWindow.vala	2017-01-15 14:50:52 +0000
@@ -27,7 +27,6 @@
     private Gtk.Button return_button;
     private Gtk.Button search_all_button;
     private Gtk.Stack button_stack;
-    private ulong task_finished_connection = 0U;
     private Gee.Deque<string> return_button_history;
     
     public static Views.InstalledView installed_view { get; private set; }
@@ -166,22 +165,11 @@
 
         unowned AppCenterCore.Client client = AppCenterCore.Client.get_default ();
         if (client.has_tasks ()) {
-            if (task_finished_connection != 0U) {
-                client.disconnect (task_finished_connection);
-            }
-
-            hide ();
-            task_finished_connection = client.notify["task-count"].connect (() => {
-                if (!visible && client.task_count == 0) {
-                    destroy ();
-                }
-            });
-
             client.cancel_updates (false); //Timeouts keep running
-            return true;
         }
 
-        return false;
+        hide ();
+        return true;
     }
 
     public void show_package (AppCenterCore.Package package) {