Merge lp:~donadigo/appcenter/fix-steam-install into lp:~elementary-apps/appcenter/appcenter

[Adam Bieńkowski]

* Fix steam installation
* Use search_names_async method

Instead of using resolve_async use search_names_async and take first package from the list (the main one).

Sorry for the mess, I actually introduced this issue by proposing branch to change search_names_async to resolve_async ;P

[Cody Garver (codygarver)]

Seems to work fine. Once it's merged I will backport it to Loki stable.

review: Approve (testing)

[Corentin Noël (tintou)]

Some inline comments

[Corentin Noël (tintou)]

Also this seems to only revert the changes made here
http://bazaar.launchpad.net/~elementary-apps/appcenter/appcenter/revision/248

[Cody Garver (codygarver)]

I have reverted this commit to trunk and set the status back to Needs Review since there were questions about the code and it didn't seem to fix Steam installation.

[Cody Garver (codygarver)]

review: Needs Fixing (testing)

Unmerged revisions

=== modified file 'src/Core/Client.vala'
--- src/Core/Client.vala	2016-08-28 20:15:43 +0000
+++ src/Core/Client.vala	2016-09-11 20:25:12 +0000
@@ -117,12 +117,13 @@
         packages_ids += null;
 
         try {
-            var results = yield search_task.resolve_async (Pk.Bitfield.from_enums (Pk.Filter.NEWEST, Pk.Filter.ARCH), packages_ids, cancellable, () => {});
+            var results = yield search_task.search_names_async (Pk.Bitfield.from_enums (Pk.Filter.NEWEST, Pk.Filter.ARCH), packages_ids, cancellable, () => {});
             packages_ids = {};
 
-            results.get_package_array ().foreach ((package) => {
-                packages_ids += package.package_id;
-            });
+            var package_array = results.get_package_array ();
+            if (package_array.length > 0) {
+                packages_ids += package_array[0].package_id;
+            }
 
             packages_ids += null;
 
@@ -183,14 +184,17 @@
         foreach (var pkg_name in package.component.get_pkgnames ()) {
             packages_ids += pkg_name;
         }
+
         packages_ids += null;
 
         try {
-            var results = yield search_task.resolve_async (Pk.Bitfield.from_enums (Pk.Filter.INSTALLED, Pk.Filter.NEWEST), packages_ids, cancellable, () => {});
+            var results = yield search_task.search_names_async (Pk.Bitfield.from_enums (Pk.Filter.INSTALLED, Pk.Filter.NEWEST), packages_ids, cancellable, () => {});
             packages_ids = {};
-            results.get_package_array ().foreach ((package) => {
-                packages_ids += package.package_id;
-            });
+
+            var package_array = results.get_package_array ();
+            if (package_array.length > 0) {
+                packages_ids += package_array[0].package_id;
+            }
 
             results = yield remove_task.remove_packages_async (packages_ids, true, true, cancellable, cb);
             exit_status = results.get_exit_code ();