Merge lp:~donadigo/appcenter/fix-get-can-launch into lp:~elementary-apps/appcenter/appcenter

[Adam Bieńkowski]

* Fix open button appearing on apps which cannot be launched

This branch fixes how get_can_launch () method works in Package class.

get_can_launch used to use Component.get_desktop_id which apparently returns a desktop id *even if it's not valid*, this had to be reworked in order to not show "Open" button in a driver page.

It now creates a DesktopAppInfo which will be verified and if the AppInfo doesn't exist, it will return null so the method will return false.

[David Hewitt (davidmhewitt)]

Stops the open button appearing on OS Updates and things you wouldn't expect to have an open button. Everything else still works.

review: Approve (code, function)

=== modified file 'src/Core/Package.vala'
--- src/Core/Package.vala	2017-02-04 17:18:30 +0000
+++ src/Core/Package.vala	2017-02-20 16:56:15 +0000
@@ -87,7 +87,10 @@
         private get { return _latest_version; }
         internal set { _latest_version = convert_version (value); }
     }
+
     private Pk.Package? pk_package = null;
+    private AppInfo? app_info;
+    private bool app_info_retrieved = false;
 
     construct {
         installed_packages = new Gee.TreeSet<Pk.Package> ();
@@ -154,14 +157,8 @@
     }
 
     public void launch () throws Error {
-        string desktop_id = component.get_desktop_id ();
-        if (desktop_id == null) {
-            throw new PackageLaunchError.DESKTOP_ID_NOT_FOUND ("desktop ID not found");
-        }
-
-        var app_info = new DesktopAppInfo (desktop_id);
         if (app_info == null) {
-            throw new PackageLaunchError.APP_INFO_NOT_FOUND ("AppInfo not found for %s ID".printf (desktop_id));
+            throw new PackageLaunchError.APP_INFO_NOT_FOUND ("AppInfo not found for package: %s".printf (get_name ()));
         }
 
         try {
@@ -332,7 +329,17 @@
     }
 
     public bool get_can_launch () {
-        return component.get_desktop_id () != null;
+        if (app_info_retrieved) {
+            return app_info != null;
+        }
+
+        string? desktop_id = component.get_desktop_id ();
+        if (desktop_id != null) {
+            app_info = new DesktopAppInfo (desktop_id);
+        }
+
+        app_info_retrieved = true;
+        return app_info != null;
     }
 
     private Pk.Package? find_package () {