Merge lp:~donadigo/appcenter/fix-empty-updates into lp:~elementary-apps/appcenter/appcenter

[Adam Bieńkowski]

* Update cache when the network is available.

This branch aims to fix bug #1615270: "AppCenter is empty if apt update has never been run". AppCenter will now try to refresh the cache after network is available. It also makes sure that the badge will be displayed when there are any updates cached.

I still don't know if it fixed the issue or not, I tested a similiar case on a normal install and it seemed to work.

Note that this branch is a prerequisite to this one and it needs to be merged first: https://code.launchpad.net/~donadigo/appcenter/fix-1609292-update-cache-ui

[kay van der Zander (kay20)]

code look fine. needs testing

=== modified file 'src/Application.vala'
--- src/Application.vala	2016-08-23 14:41:30 +0000
+++ src/Application.vala	2016-08-23 14:41:30 +0000
@@ -56,15 +56,23 @@
     }
 
     public override void activate () {
+        var client = AppCenterCore.Client.get_default ();
         if (silent) {
-            AppCenterCore.Client.get_default ().update_cache.begin ();
+            NetworkMonitor.get_default ().network_changed.connect ((available) => {
+                if (available) {
+                    client.update_cache.begin (true);
+                }
+            });
+
+            client.update_cache.begin ();
+        
             silent = false;
             hold ();
             return;
         }
 
         if (main_window == null) {
-            AppCenterCore.Client.get_default ().update_cache.begin (true);
+            client.update_cache.begin (true);
 
             main_window = new MainWindow (this);
             main_window.destroy.connect (() => {
@@ -77,7 +85,7 @@
                 main_window.go_to_installed ();
             }
         } else {
-            AppCenterCore.Client.get_default ().interface_cancellable.reset ();
+            client.interface_cancellable.reset ();
         }
 
         main_window.present ();

=== modified file 'src/Core/Client.vala'
--- src/Core/Client.vala	2016-08-23 14:41:30 +0000
+++ src/Core/Client.vala	2016-08-23 14:41:30 +0000
@@ -391,10 +391,11 @@
             try {
                 yield refresh_task.refresh_cache_async (false, null, (t, p) => { });
                 last_cache_update = new DateTime.now_local ();
-                refresh_updates.begin ();
             } catch (Error e) {
                 critical (e.message);
             }
+
+            refresh_updates.begin ();
         }
 
         GLib.Timeout.add_seconds (60*60*24, () => {