Merge lp:~donadigo/appcenter/fix-app-installation into lp:~elementary-apps/appcenter/appcenter

[Adam Bieńkowski]

- Fix bug #1594070: "Cannot install Gimp using AppCenter".
- Fix installed apps would take up much more space than manually installed.

Fixes bug #1594070: "Cannot install Gimp using AppCenter".

This branch fixes two major issues in how AppCenter will install the packages:
1. Apps like gimp would not install due to calling search_names method which returns *all* packages that match "gimp" not the one that we are looking for.

2. Because of that also, when you would install some app in the AppCenter it would take up ridiculous sizes of disk space because of installing all packages (including docs, dev libraries, help packages).

We now call reslove_async which returns only package names that are needed in order to install specific app.

=== modified file 'src/Core/Client.vala'
--- src/Core/Client.vala	2016-07-02 21:54:31 +0000
+++ src/Core/Client.vala	2016-07-18 17:29:43 +0000
@@ -115,14 +115,17 @@
         foreach (var pkg_name in package.component.get_pkgnames ()) {
             packages_ids += pkg_name;
         }
+
         packages_ids += null;
 
         try {
-            var results = yield search_task.search_names_async (Pk.Bitfield.from_enums (Pk.Filter.NEWEST, Pk.Filter.ARCH), packages_ids, cancellable, () => {});
+            var results = yield search_task.resolve_async (Pk.Bitfield.from_enums (Pk.Filter.NEWEST, Pk.Filter.ARCH), packages_ids, cancellable, () => {});
             packages_ids = {};
+
             results.get_package_array ().foreach ((package) => {
                 packages_ids += package.package_id;
             });
+
             packages_ids += null;
 
             results = yield install_task.install_packages_async (packages_ids, cancellable, cb);
@@ -151,6 +154,7 @@
         foreach (var pk_package in package.change_information.changes) {
             packages_ids += pk_package.get_id ();
         }
+        
         packages_ids += null;
 
         try {
@@ -184,8 +188,7 @@
         packages_ids += null;
 
         try {
-            var filter = Pk.Bitfield.from_enums (Pk.Filter.INSTALLED, Pk.Filter.NEWEST);
-            var results = yield search_task.search_names_async (filter, packages_ids, cancellable, () => {});
+            var results = yield search_task.resolve_async (Pk.Bitfield.from_enums (Pk.Filter.INSTALLED, Pk.Filter.NEWEST), packages_ids, cancellable, () => {});
             packages_ids = {};
             results.get_package_array ().foreach ((package) => {
                 packages_ids += package.package_id;

=== modified file 'src/Core/Task.vala'
--- src/Core/Task.vala	2016-05-31 22:33:00 +0000
+++ src/Core/Task.vala	2016-07-18 17:29:43 +0000
@@ -19,10 +19,6 @@
  */
 
 public class AppCenter.Task : Pk.Task {
-    public Task () {
-        
-    }
-
     public override void untrusted_question (uint request, Pk.Results results) {
         user_accepted (request);
     }