Merge lp:~domsense/web-addons/adding_web_field_style into lp:~webaddons-core-editors/web-addons/6.1

[Lorenzo Battistini]

Allows to specify different colors or
    CSS class per field in view definition.

    Three new attributes will be available on the field element of a view:
        `bgcolor` for setting the background color
        `fgcolor` for setting the foreground color (basically the text)
        `ccsclass` for setting a custom CSS class to be applied on the field

    `bg/fgcolor` are very useful for people that only want to change some field color without
    having to deal with CSS.

    NOTE: you must apply a simple patch to this server's file

        `server/openerp/addons/base/rng/view.rng`

    Just use the patch provided by this module (see server-view.rng.patch in the root of the package).

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

Is it not possible to patch the file when this module is installed and to unpatch when the module is uninstalled? This would greatly simplify installation for end users.

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

Also: the README.txt file does not seem to match the copyright information in the file headers.

[Niels Huylebroeck (red15)]

Noticed a typo in the description: ccsclass (should've been cssclass i presume)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I'm not in favor to include addons in the community addons which needs to manually patch the server or the addons.

By the way, there is a way, a bit tricky I have to admit, to use the 'options' attribute on the fields.

Basically, the options defined in a field are available in this.node.attrs.options and are stored as JSON. That's far to be as convenient as new attributes for bgcolor, fgcolor and cssclass, but this method does not require to patch the server.

Example (customize the name of the 'create' button on one2many fields):

    openerp.web_custom = function (openerp) {
        var QWeb = openerp.web.qweb;

        var _t = openerp.web._t;

        openerp.web.form.FieldOne2Many.include({

            load_views: function() {
                var self = this;
                var result = this._super();
                var custom_options_str = this.node.attrs.options || '{}';
                var custom_options = JSON.parse(custom_options_str);
                _.each(this.views, function(view) {
                    // apply the custom options defined in the xml field like
                    // <field name="descr_ids" options='{"addable": "+"}'>
                    _.extend(view.options, custom_options);

                    // re-apply the read-only deactivation because they
                    // have the priority in all cases
                    if(view.view_type === "list") {
                        if (self.is_readonly()) {
                            view.options.addable = null;
                            view.options.deletable = null;
                            view.options.isClarkGable = false;
                        }
                    } else if (view.view_type === "form") {
                        if (self.is_readonly()) {
                            view.view_type = 'page';
                        }
                    }
                });
                return result;
            }

        });
    };

review: Abstain

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

I'm -1 on this MP, because of the patch requirement

review: Needs Fixing

[Davide Corio (enlightx-deactivatedaccount)]

personally i won't spend time on this addon since on v7, webclient is changed a lot from this point of view and allows things like style="background-color:green;", then this module won't be that useful in the future

[Davide Corio (enlightx-deactivatedaccount)]

the first "won't" was actually a "would not" :-)

[Holger Brunn (Therp) (hbrunn)]

are we going to do something with this one or should we finally reject it because of the patch requirement which would be my choice?

review: Disapprove

[Lorenzo Battistini (elbati)]

On 06/03/2013 03:19 PM, Holger Brunn (Therp) wrote:
> are we going to do something with this one or should we finally reject it because of the patch requirement which would be my choice?

It can be rejected.

Unmerged revisions

3. By Lorenzo Battistini on 2013-01-20

[ADD] web_field_style

=== added directory 'web_field_style'
=== added file 'web_field_style/AUTHORS.txt'
--- web_field_style/AUTHORS.txt	1970-01-01 00:00:00 +0000
+++ web_field_style/AUTHORS.txt	2013-01-20 15:31:20 +0000
@@ -0,0 +1,4 @@
+Authors
+=======
+
+Simone Orsi <[e-mail]> [simahawk]

=== added file 'web_field_style/__init__.py'
--- web_field_style/__init__.py	1970-01-01 00:00:00 +0000
+++ web_field_style/__init__.py	2013-01-20 15:31:20 +0000
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#    
+#    Copyright (C) 2012-2013 Agile Business Group sagl
+#    (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################

=== added file 'web_field_style/__openerp__.py'
--- web_field_style/__openerp__.py	1970-01-01 00:00:00 +0000
+++ web_field_style/__openerp__.py	2013-01-20 15:31:20 +0000
@@ -0,0 +1,58 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#    
+#    Copyright (C) 2012-2013 Agile Business Group sagl
+#    (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Field Style',
+    'version': '1.0',
+    'category': 'web',
+    'description': """Allows to specify different colors or 
+    CSS class per field in view definition.
+
+    Three new attributes will be available on the field element of a view:
+        `bgcolor` for setting the background color
+        `fgcolor` for setting the foreground color (basically the text)
+        `ccsclass` for setting a custom CSS class to be applied on the field
+
+    `bg/fgcolor` are very useful for people that only want to change some field color without
+    having to deal with CSS.
+
+    NOTE: you must apply a simple patch to this server's file
+
+        `server/openerp/addons/base/rng/view.rng`
+
+    Just use the patch provided by this module (see server-view.rng.patch in the root of the package).
+    
+    """,
+    'author': 'Agile Business Group & Domsense',
+    'website': 'http://www.agilebg.com',
+    'license': 'AGPL-3',
+    'depends': ['web'],
+    'data': [],
+    'active': False,
+    'installable': True,
+    'js': [
+        'static/js/web_field_style.js',
+    ],
+    'qweb': [
+        'static/xml/web_field_style.xml',
+    ],
+}
+

=== added file 'web_field_style/server-view.rng.patch'
--- web_field_style/server-view.rng.patch	1970-01-01 00:00:00 +0000
+++ web_field_style/server-view.rng.patch	2013-01-20 15:31:20 +0000
@@ -0,0 +1,14 @@
+=== modified file 'openerp/addons/base/rng/view.rng'
+--- openerp/addons/base/rng/view.rng	2012-02-13 10:17:58 +0000
++++ openerp/addons/base/rng/view.rng	2012-08-13 10:13:00 +0000
+@@ -500,6 +500,9 @@
+             <rng:attribute name="name" />
+             <rng:ref name="overload"/>
+             <rng:ref name="access_rights"/>
++            <rng:optional><rng:attribute name="bgcolor"/></rng:optional>
++            <rng:optional><rng:attribute name="fgcolor"/></rng:optional>
++            <rng:optional><rng:attribute name="cssclass"/></rng:optional>
+             <rng:optional><rng:attribute name="domain_filter"/></rng:optional>
+             <rng:optional><rng:attribute name="attrs"/></rng:optional>
+             <rng:optional><rng:attribute name="string"/></rng:optional>
+

=== added directory 'web_field_style/static'
=== added directory 'web_field_style/static/js'
=== added file 'web_field_style/static/js/web_field_style.js'
--- web_field_style/static/js/web_field_style.js	1970-01-01 00:00:00 +0000
+++ web_field_style/static/js/web_field_style.js	2013-01-20 15:31:20 +0000
@@ -0,0 +1,42 @@
+//  @@@ web_field_style custom JS @@@
+
+openerp.web_field_style = function(openerp) {
+
+    openerp.web.form.Field.include({
+
+        default_style: 'width:100%;',
+
+        init: function(view, node) {
+            this._super(view, node);
+            this.setup_styles(view, node);
+        },
+
+        setup_styles : function(view, node){
+            // style
+            // this is done for allowing ppl to set up different colors per field
+            // without having to deal with css
+            var style = this.default_style;
+            if(node.attrs.bgcolor){
+                style += 'background-color:' + node.attrs.bgcolor + ' !important;';
+            }
+            if(node.attrs.fgcolor){
+                style += 'color:' + node.attrs.fgcolor + ' !important;';
+            }
+            this.input_style = style;
+            // css class
+            var cssclass = 'field_' + this.type;
+            cssclass += _(['integer', 'float', 'float_time']).contains(this.type) ? ' oe-number' : '';
+            if(node.attrs.cssclass){
+                cssclass += ' ' + node.attrs.cssclass;
+            }
+            this.input_cssclass = cssclass;
+        }
+    });
+
+
+    // openerp.web.form.FieldChar = openerp.web.form.FieldChar.extend({
+    //     default_style: 'width:100%;',
+
+    // });
+
+}

=== added directory 'web_field_style/static/xml'
=== added file 'web_field_style/static/xml/web_field_style.xml'
--- web_field_style/static/xml/web_field_style.xml	1970-01-01 00:00:00 +0000
+++ web_field_style/static/xml/web_field_style.xml	2013-01-20 15:31:20 +0000
@@ -0,0 +1,92 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<templates>
+
+<t t-name="FieldChar" t-extend="FieldChar">
+    <t t-jquery="input" t-operation="replace">
+        <input
+            t-att-type="widget.password ? 'password' : 'text'"
+            size="1"
+            t-att-name="widget.name"
+            t-att-id="widget.element_id"
+            t-att-maxlength="widget.field.size"
+            t-att-class="widget.input_cssclass"
+            t-att-style="widget.input_style"
+          />
+    </t>
+</t>
+
+<t t-name="FieldText" t-extend="FieldText">
+    <t t-jquery="textarea" t-operation="replace">
+        <textarea
+            rows="6"
+            t-att-name="widget.name"
+            t-att-id="widget.element_id"
+            t-att-maxlength="widget.field.size"
+            t-att-class="widget.input_cssclass"
+            t-att-style="widget.input_style"
+             />
+    </t>
+</t>
+
+<t t-name="web.datetimepicker">
+    <div class="oe_datepicker_root">
+        <input
+            type="text"
+            size="1"
+            class="oe_datepicker_container"
+            disabled="disabled"
+            style="display: none;"
+            />
+        <input
+            type="text"
+            size="1"
+            t-att-style="widget.input_style"
+            t-att-name="widget.name"
+            t-attf-class="oe_datepicker_master field_#{widget.type_of_date} #{widget.input_cssclass}"
+            />
+        <img
+            class="oe_input_icon oe_datepicker_trigger"
+            t-att-src='_s + "/web/static/src/img/ui/field_calendar.png"'
+            title="Select date"
+            width="16"
+            height="16"
+            border="0"
+            />
+    </div>
+</t>
+
+<t t-name="FieldSelection">
+    <select
+        t-att-name="widget.name"
+        t-att-id="widget.element_id"
+        t-att-class="widget.input_cssclass"
+        t-att-style="widget.input_style">
+            <t t-foreach="widget.values" t-as="option">
+                <option><t t-esc="option[1]"/></option>
+            </t>
+    </select>
+</t>
+
+<t t-name="FieldReference">
+    <table border="0" width="100%" cellpadding="0" cellspacing="0"
+        t-attf-class="oe_frame oe_forms #{widget.input_cssclass}">
+    <tr>
+        <td t-attf-class="oe_form_frame_cell oe_form_selection #{widget.selection.element_class}">
+            <t t-raw="widget.selection.render()"/>
+        </td>
+        <td t-attf-class="oe_form_frame_cell oe_form_many2one #{widget.m2o.element_class}" nowrap="true" style="display: none">
+            <t t-raw="widget.m2o.render()"/>
+        </td>
+    </tr>
+    </table>
+</t>
+<t t-name="FieldBoolean">
+    <input type="checkbox"
+        t-att-name="widget.name"
+        t-att-class="widget.input_cssclass"
+        t-att-style="widget.input_style"
+        />
+</t>
+
+</templates>
\ No newline at end of file