Merge lp:~domsense/domsense-agilebg-addons/ea_import_fix_missing_value_rows into lp:~domsense/domsense-agilebg-addons/ea_import

Proposed by Alex Comba - Agile BG
Status: Merged
Merged at revision: 27
Proposed branch: lp:~domsense/domsense-agilebg-addons/ea_import_fix_missing_value_rows
Merge into: lp:~domsense/domsense-agilebg-addons/ea_import
Diff against target: 28 lines (+3/-4)
1 file modified
ea_import/ea_import_template.py (+3/-4)
To merge this branch: bzr merge lp:~domsense/domsense-agilebg-addons/ea_import_fix_missing_value_rows
Reviewer Review Type Date Requested Status
Agile Business Group Pending
Review via email: mp+151453@code.launchpad.net

Commit message

[FIX] adding key_field even if template_line.key_field has no value

Description of the change

Adding key_field even if template_line.key_field has no value

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ea_import/ea_import_template.py'
2--- ea_import/ea_import_template.py 2013-01-03 11:10:00 +0000
3+++ ea_import/ea_import_template.py 2013-03-04 10:38:30 +0000
4@@ -48,12 +48,12 @@
5 for template_line in template.line_ids:
6 field_name = template_line.target_field.name
7 value = template_line.get_field(record_list, testing=True)
8+ if template_line.key_field:
9+ upd_key.append((template_line.target_field.name, '=', value))
10 if template_line.default_value and not value:
11 value = template_line.default_value
12 if value:
13 record.update({field_name: value})
14- if template_line.key_field:
15- upd_key.append((template_line.target_field.name, '=', value))
16 else:
17 if template_line.required:
18 ready_to_create_new = False
19@@ -83,8 +83,7 @@
20 value = template_line.default_value
21 else:
22 value = template_line.get_field(input_list, testing=True)
23- if value:
24- key.append((field_name, '=', value))
25+ key.append((field_name, '=', value))
26 if not key:
27 return [None]
28 if template.update_current:

Subscribers

People subscribed via source and target branches

to all changes: