Merge lp:~domsense/domsense-agilebg-addons/ea_import_fix_default_false_value into lp:~domsense/domsense-agilebg-addons/ea_import

Proposed by Alex Comba - Agile BG
Status: Merged
Merged at revision: 29
Proposed branch: lp:~domsense/domsense-agilebg-addons/ea_import_fix_default_false_value
Merge into: lp:~domsense/domsense-agilebg-addons/ea_import
Diff against target: 28 lines (+3/-3)
2 files modified
ea_import/ea_import_template.py (+2/-2)
ea_import/ea_import_template_line.py (+1/-1)
To merge this branch: bzr merge lp:~domsense/domsense-agilebg-addons/ea_import_fix_default_false_value
Reviewer Review Type Date Requested Status
Leonardo Pistone (community) Approve
Review via email: mp+186260@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Leonardo Pistone (lepistone) wrote :

LGTM, no test

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ea_import/ea_import_template.py'
2--- ea_import/ea_import_template.py 2013-03-01 15:55:00 +0000
3+++ ea_import/ea_import_template.py 2013-09-18 08:27:57 +0000
4@@ -50,9 +50,9 @@
5 value = template_line.get_field(record_list, testing=True)
6 if template_line.key_field:
7 upd_key.append((template_line.target_field.name, '=', value))
8- if template_line.default_value and not value:
9+ if template_line.default_value and value is None:
10 value = template_line.default_value
11- if value:
12+ if value is not None:
13 record.update({field_name: value})
14 else:
15 if template_line.required:
16
17=== modified file 'ea_import/ea_import_template_line.py'
18--- ea_import/ea_import_template_line.py 2013-03-22 16:54:28 +0000
19+++ ea_import/ea_import_template_line.py 2013-09-18 08:27:57 +0000
20@@ -230,7 +230,7 @@
21 result = target_obj_pool.search(cr, uid, [(template_line.related_field.name, '=', target_string)], context=context)
22 if testing:
23 test_many2one_result(result, template_line, target_string)
24- return result and result[0] or False
25+ return result and result[0] or None
26 elif not result:
27 return None
28 else:

Subscribers

People subscribed via source and target branches

to all changes: