Merge lp:~domcleal/ibid/karma-actions into lp:ibid

Proposed by Dominic Cleal
Status: Needs review
Proposed branch: lp:~domcleal/ibid/karma-actions
Merge into: lp:ibid
Diff against target: 17 lines (+2/-1)
1 file modified
ibid/plugins/karma.py (+2/-1)
To merge this branch: bzr merge lp:~domcleal/ibid/karma-actions
Reviewer Review Type Date Requested Status
Dominic Cleal (community) Needs Resubmitting
Stefano Rivera Needs Fixing
Review via email: mp+83938@code.launchpad.net

Description of the change

Allows karma changes in actions too, when in non-addressed mode.

To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

I assume you haven't actually tested it? :)

review: Needs Fixing
Revision history for this message
Dominic Cleal (domcleal) wrote :

> I assume you haven't actually tested it? :)

Clearly not! Sorry for the noise, try now with r1043 :)

review: Needs Resubmitting
lp:~domcleal/ibid/karma-actions updated
1043. By Dominic Cleal

Fix variable scope

Unmerged revisions

1043. By Dominic Cleal

Fix variable scope

1042. By Dominic Cleal

Match karma in actions too when not in addressed mode

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/plugins/karma.py'
2--- ibid/plugins/karma.py 2011-01-23 13:19:55 +0000
3+++ ibid/plugins/karma.py 2011-11-30 19:22:49 +0000
4@@ -74,11 +74,12 @@
5 " which a karma won't be forgotten", 0)
6
7 def setup(self):
8- # When not addressed, match karma changes in any text
9+ # When not addressed, match karma changes in any text or actions
10 if self.addressed:
11 matchpat = r'^(.+?)\s*(%s)\s*(?:[[{(]+\s*(.+?)\s*[\]})]+)?$'
12 else:
13 matchpat = r'(\S*\w\S*)(%s)(?:$|[\s,;\.\?!])'
14+ self.event_types = (u'message', u'action')
15
16 self.increase_reg = self.regex_tokens(self.increase)
17 self.decrease_reg = self.regex_tokens(self.decrease)

Subscribers

People subscribed via source and target branches

to all changes: