Code review comment for ~doismellburning/launchpad:bail-on-fail-on-db-setup

Revision history for this message
Colin Watson (cjwatson) wrote :

I normally just use "code" or something similarly not-very-nymous for this sort of thing, but this is fine.

If you prefer, you could also consider this style, which may be neater in this case:

  if sudo grep -qs "^auto" /etc/postgresql/$try_pgversion/main/start.conf; then
    pgversion="$try_pgversion"
    break
  fi

and:

  if ! sudo grep -q "port.*5432" /etc/postgresql/$pgversion/main/postgresql.conf; then
    echo "..."
  fi

review: Approve

« Back to merge proposal