Merge ~doismellburning/launchpad:ogp into launchpad:master

Proposed by Kristian Glass
Status: Merged
Approved by: Kristian Glass
Approved revision: 46763118481345fccc743936fce6e85f9d014c16
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~doismellburning/launchpad:ogp
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/bugs/browser/tests/test_bug_views.py (+1/-1)
Reviewer Review Type Date Requested Status
Ioana Lasc (community) Approve
Review via email: mp+385741@code.launchpad.net

Commit message

Update expected count in TestEmailObfuscated to reflect OpenGraph tags

Fixes test failure introduced in
62f99f9768eae07feb0bdc4c24e4d6e5fe1a00dc - OpenGraph metadata tags mean
there's an additional instance of a mentioned email address on a bug
page

To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) wrote :

yep, looks good.

review: Approve
~doismellburning/launchpad:ogp updated
4676311... by Kristian Glass

Update expected count in TestEmailObfuscated to reflect OpenGraph tags

Fixes test failure introduced in
62f99f9768eae07feb0bdc4c24e4d6e5fe1a00dc - OpenGraph metadata tags mean
there's an additional instance of a mentioned email address on a bug
page

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/bugs/browser/tests/test_bug_views.py b/lib/lp/bugs/browser/tests/test_bug_views.py
2index d6c4eaf..149bf51 100644
3--- a/lib/lp/bugs/browser/tests/test_bug_views.py
4+++ b/lib/lp/bugs/browser/tests/test_bug_views.py
5@@ -186,7 +186,7 @@ class TestEmailObfuscated(BrowserTestCase):
6 def test_user_sees_email_address(self):
7 """A logged-in user can see the email address on the page."""
8 browser = self.getBrowserForBugWithEmail(no_login=False)
9- self.assertEqual(7, browser.contents.count(self.email_address))
10+ self.assertEqual(8, browser.contents.count(self.email_address))
11
12 def test_anonymous_sees_not_email_address(self):
13 """The anonymous user cannot see the email address on the page."""

Subscribers

People subscribed via source and target branches

to status/vote changes: