Merge lp:~doflah/ubuntu-weather-app/fix_owm_link into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Dennis O'Flaherty
Status: Merged
Approved by: Martin Borho
Approved revision: 165
Merged at revision: 172
Proposed branch: lp:~doflah/ubuntu-weather-app/fix_owm_link
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 12 lines (+1/-1)
1 file modified
components/LocationTab.qml (+1/-1)
To merge this branch: bzr merge lp:~doflah/ubuntu-weather-app/fix_owm_link
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Martin Borho Approve
Review via email: mp+198868@code.launchpad.net

Commit message

Load weather for the selected city when clicking the OWM logo instead of loading for London.

Description of the change

Load weather for the selected city when clicking the OWM logo instead of loading for London.

To post a comment you must log in.
Revision history for this message
Martin Borho (martin-borho) wrote :

Looks okay for me!

Sorry for the delay :(

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~doflah/ubuntu-weather-app/fix_owm_link/+merge/198868/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components/LocationTab.qml'
2--- components/LocationTab.qml 2013-10-08 20:26:43 +0000
3+++ components/LocationTab.qml 2013-12-13 04:14:35 +0000
4@@ -183,7 +183,7 @@
5 fillMode: Image.PreserveAspectFit
6 MouseArea {
7 anchors.fill: parent
8- onClicked: Qt.openUrlExternally("http://m.openweathermap.org")
9+ onClicked: Qt.openUrlExternally("http://m.openweathermap.org/city/" + locationData.location.services.openweathermap)
10 }
11 }
12 }

Subscribers

People subscribed via source and target branches