Merge lp:~doflah/ubuntu-calendar-app/ubuntu-calendar-app into lp:ubuntu-calendar-app

Proposed by Dennis O'Flaherty
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 99
Merged at revision: 103
Proposed branch: lp:~doflah/ubuntu-calendar-app/ubuntu-calendar-app
Merge into: lp:ubuntu-calendar-app
Diff against target: 19 lines (+2/-1)
1 file modified
MonthComponent.qml (+2/-1)
To merge this branch: bzr merge lp:~doflah/ubuntu-calendar-app/ubuntu-calendar-app
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Olivier Tilloy (community) Approve
Review via email: mp+183554@code.launchpad.net

Commit message

Color the padding dates in each month of the YearView gray to match the style of the MonthView.

Description of the change

Color the padding dates in each month of the YearView gray to match the style of the MonthView. It's a small change but it is combination of making things consistent and testing out the commit/merge proposal process.

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good!
Note that there are new visual designs for all the views, which Kunal is currently working on. The year view, in particular, is being revamped. Still, this change makes sense in the meantime.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~dennis-oflaherty/ubuntu-calendar-app/ubuntu-calendar-app/+merge/183554/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MonthComponent.qml'
2--- MonthComponent.qml 2013-08-10 06:06:18 +0000
3+++ MonthComponent.qml 2013-09-03 01:07:15 +0000
4@@ -73,13 +73,14 @@
5
6 property var day: parent.monthStart.addDays(index)
7 property var isToday: day.isSameDay(intern.now)
8+ property bool isPaddingDate: day.getMonth() != root.date.getMonth()
9
10 text: day.getDate()
11 horizontalAlignment: Text.AlignHCenter
12 width: dummy.width
13 height: dummy.height
14 font.pointSize: dummy.font.pointSize
15- color: isToday ? Color.ubuntuOrange : dummy.color
16+ color: isToday ? Color.ubuntuOrange : (isPaddingDate ? Color.warmGrey : dummy.color)
17 scale: isToday ? 1.5 : 1.
18 }
19 }

Subscribers

People subscribed via source and target branches

to status/vote changes: