This restores the nested NSApplicationMain and default run loop
usage. Without it the Java AWT integration will start its own
event loop, effectively blocking any non-system event processing.
Reproducible via "Tools - Macros - Organize Macros - BeanShell...
- LibreOffice Macros - HelloWorld - helloworld.bsh - Edit".
The blocking can be prevented by overriding NSApplication::run and
running our own event loop using Application::Execute. But this
still doesn't show the Java AWT editor window and I couldn't find
any information how to fix this.
Since OSX now is a VCL plugin, this can't restore the old hook
mechanism, but instead adds a new function to SalInstance.
SalInstance initialization happens at InitVCL() start just a
little bit later in the call stack.
Somehow NSApplicationMain manages to run the Java VM in an extra
thread, so it doesn't block the main loop. Probably this could
also be handled by LO starting the JVM as a thread.
Further information for an implementation eventually can be found
in the "Technical Note TN2147" "JNI Development on Mac OS X."
68c85f3...
by
Michael Stahl <email address hidden>
sw_redlinehide: fix assert caused by buggy lcl_ModifyOfst
converting ooo67907-1.doc to ODT asserts in fillSoftPageBreakList()
while mapping an invalid (too large) GetOfst() of a follow frame.
There are some problems with the lcl_ModifyOfst() implementation and
usage:
1. the implementation iterates over all follows; but the follows will
get the same SwClientNotify() call as the frame itself, so in effect
the follows' Ofsts will be modified multiple times
2. the calls to lcl_ModifyOfst pass in a positive nLen whether the
text is deleted or inserted; surely for deletions the Ofst should be
subtracted from instead of added to
3. the special-casing of RES_DEL_CHR to COMPLETE_STRING while
RES_DEL_TXT uses the length does not appear to be justified
The assert happens since b15f1ed2a1df45a57b587ac90efa90c1c18866fc
but the lcl_ModifyOfst logic never made sense.
Change-Id: Ie92628515bbee0fcc2123eb412057d8c0fd0b2f1
Reviewed-on: https://gerrit.libreoffice.org/66679
Tested-by: Jenkins
Reviewed-by: Michael Stahl <email address hidden>
(cherry picked from commit 0acde7514e666fc04805fd36503bd174162336ca)
Reviewed-on: https://gerrit.libreoffice.org/66683
Reviewed-by: Thorsten Behrens <email address hidden>
(cherry picked from commit d246374dc71ee557de5811e1971a82e0f6145509)
Reviewed-on: https://gerrit.libreoffice.org/66722
Reviewed-by: Miklos Vajna <email address hidden>
Reviewed-by: Christian Lohmaier <email address hidden>
Tested-by: Christian Lohmaier <email address hidden>
de259fd...
by
Christian Lohmaier <email address hidden>
update credits
Change-Id: Ib5e07977b6dd15b533e94185ecb80d0d6587b7c7
(cherry picked from commit 2a4cba62438de7f3dc2ccc79cd2ee013a99bb990)
(cherry picked from commit 09f7cc59735ce0f43fb4f6a531feccf732cc25f0)
d5344e4...
by
=?utf-8?q?Caol=C3=A1n_McNamara?= <email address hidden>
