df-libreoffice:feature/spellig_popup_SID

Last commit made on 2019-11-18
Get this branch:
git clone -b feature/spellig_popup_SID https://git.launchpad.net/df-libreoffice
Members of The Document Foundation can upload to this branch. Log in for directions.

Branch merges

Branch information

Name:
feature/spellig_popup_SID
Repository:
lp:df-libreoffice

Recent commits

6f09a97... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

SpellingPopup: Replace the tunneled context menu.

Send the menu structure instead using LOK_CALLBACK_CONTEXT_MENU.
We need to set commands for menu items to make fillPopupMenu()
method work.
We also need to check whether there is any selection during execution
of menu items. In case of LO core execution the suspicious text is
selected, however in case of LO online, there is no selection.

Change-Id: Id696ee9976d11f6b57e23a3bcc5b483a1d486639

4704d39... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

Dispatch: Make fillPopupMenu() method accessible from other modules.

No functional change.

Change-Id: Ifaa6ff038277ef5702ac38d90c7461d664b0aee4

0549ac6... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

SpellingPopup: lok: Hide unusable items for online

MN_EXPLANATION_LINK is some link, but it's exectued internally,
which means the the link would be executed on the serves side and
not on the client's browser.
m_nCorrectMenuId is a sub menu which allows to specify new autocorrect
rules. Since m_nAddId is also disabled, I expect that extending
the dictionaries / autocorrect rule might be a problem for online.

Change-Id: Id6e8ed078f90a4f25a335a3ab5ec0e3056db648d

6100ba8... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

SpellingPopup: Convert suggestion menu items to use slot ID.

Change-Id: Icf1f50d04ab5e7ba467d68613f4101a3fe48589b

c2357aa... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

SpellingPopup: Remove m_aSuggestions member variable

We don't need it after the construction. The text is stored by the
menu item.

Change-Id: I54b0392b4564e76d405824bb297e6f993a24a5fb

16af8d3... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

SpellingPopup: Convert "IgnoreAll" menu item to use a slot ID (spelling).

When the popup is in spelling mode. "IgnoreAll_Spelling" rule
triggers this method.

Change-Id: Ia1e1877f8501beff29f09bc33621c8f03008b7e8

aad5066... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

SpellingPopup: Convert "IgnoreAll" menu item to use a slot ID (grammar).

When the popup is in grammar mode. "IgnoreAll_Grammar" rule
triggers this method.
When openning the spelling popup we have the suspicious text selected,
so we don't need the mouse position to apply the changes.
I updated GetGrammarCorrection() method accordingly.

Change-Id: Iaf86544ea5f7dbc4afa2889772a5a38c5fd5707e

4fad0a9... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

SpellingPopup: Convert "Ignore" menu item to use a slot ID.

Introduced a new slot id SID_APPLY_SPELLING, which can be used
to apply any spelling / grammar related changes (e.g. ignore,
ignore all, replace with suggestion, add to dictionary).
In this commit, only the simple ignore is implemented.

Change-Id: I06ab84efeb955cc02ce3ff531bd8b5c20ddced9e

ddb2fcb... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

SpellingPopup: Move setting UPN_IS_GRAMMAR_INTERACTIVE to the constructor.

Change-Id: Ief5470e0a61f0ca40549ab6d3768c795c3f04510

07cfd38... by =?utf-8?q?Tam=C3=A1s_Zolnai?= <email address hidden>

SpellingPopup: lok: Also hide the add menu

Change-Id: Ic6b10d579fe1fb0afe5e80244e84ed456dc6cc87