...from ScFormatEntry to ScCondFormatEntry instead of just ScConditionEntry,
introduced with 3f614f431475e1bf3bb3bbeac59b0681309628b7 "tdf#95295: don't add
duplicate conditional formats". Caused e.g. CppunitTest_sc_bugfix_test to fail
under -fsanitize=vptr, when trying to downcast a ScValidationData.
This tries to make sure that on copy, any conditional formatting
that has same entries (conditions and formats) as another condition
in the table, is not appended to the conditions list, but updates
existing condition's range. This should prevent multiplication of
entries with duplicating conditions and formats, and fragmenting
ranges.
Existing unit tests had to be adjusted, because they had ensured
exactly that behaviour that is changed in this commit: that new
items are added to the list, and e.g. multiple elements are created
when a single cell is copied to a range.
44d74f1...
by
Samuel Mehrbrodt <email address hidden>
unopkg: Log deployment output with the same logger as unopkg
This prevents overwriting the existing logfile by
using the same logger as unopkg does.
Reviewed-on: https://gerrit.libreoffice.org/62393
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <email address hidden>
(cherry picked from commit 5bd0212b54ea8c98fe401e8b1ad6d0b626a4b7e1)
Change-Id: Iaad4c5b99a4f428d3a4ad8a046c88404aecb5652
(cherry picked from commit ad9d295c13d4c176643a26898f1b697b2a406ee7)
8ffe475...
by
Samuel Mehrbrodt <email address hidden>
unopkg: Write to console when no UNO available
Change-Id: I159b7e85f53e33c5359cca83aa958387d888f6a2
Reviewed-on: https://gerrit.libreoffice.org/62391
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <email address hidden>
(cherry picked from commit d2a4fac09bc6d17b85fd34a3f0777ecc5e3bd286)
(cherry picked from commit 40c4c0f17ad5871861b64014fc7f8ae04d3f8971)
84e12b1...
by
Samuel Mehrbrodt <email address hidden>
Introduce SimpleTextFormatter and format unopkg output using it
This will write log messages as plain text (no timestamp and other stuff
like PlainTextFormatter).
Warnings and errors will be prefixed accordingly.
Reviewed-on: https://gerrit.libreoffice.org/62370
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <email address hidden>
(cherry picked from commit e4583f1ce81fc76dbfe55bcfd86d63ffe3518e5b)
Change-Id: Id82512d7dd3907a4c7cd69a963a375966189dc20
(cherry picked from commit f5b786e8749ce5622138f800ca620942e8921854)
706da53...
by
Samuel Mehrbrodt <email address hidden>
Log unopkg errors to log file if requested
Before only the output generated by extension add/remove/... functions
were logged to file, but not the error messages of unopkg itself.
Change-Id: I4451aa51e2877ae48c453ee4791e36d970832567
Reviewed-on: https://gerrit.libreoffice.org/62369
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <email address hidden>
(cherry picked from commit e8d130e7c6b2ff2a941372f386ee46fe8a95f218)
7bedc5c...
by
Samuel Mehrbrodt <email address hidden>
Update .gitreview
9bc8f6d...
by
Samuel Mehrbrodt <email address hidden>
Sync extension registration on startup
There are cases where the extension registration becomes invalid
(empty rdb files) which leads to extensions not starting up,
although installed and active.
Syncing extension repos on startup fixes that.
The performance impact is negligible (1ms in my measurements).
Change-Id: I10475ce6a054b43c4591b17a8486648ca6a30068
Reviewed-on: https://gerrit.libreoffice.org/61943
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <email address hidden>
(cherry picked from commit 8959bb300b05be9fafbf30e553b35fb517bdf786)
