df-libreoffice:feature/OperationSmiley

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

fcbacef... by Armin Le Grand <<email address hidden> (CIB)> on 2018-03-17

OperationSmiley: Adapted TestDocument

The OperationSmiley fix is about removing the old hack
that for CustomShapes in top-left and bottom-right points
were added. In the ScTiledRenderingTest::testGraphicInvalidate
UnitTest using this document exactly that top-left wrong polygon
was hit which is now no longer there. The used shape was an
ellipse, so this makes a difference - there *is* no geometry
in the top-left corner of this shape. To fix that, I exchanged
the ellipe CustomShape with a rectangle CustomShape. That way,
the old hit behaviour will be replicated.

Change-Id: I4b96ad79ba91166f097207226577d34087625589

75a376b... by Armin Le Grand <<email address hidden> (CIB)> on 2018-03-16

OperationSmiley: Corrected shadowing of local variables

Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa

e739d02... by Armin Le Grand <<email address hidden> (CIB)> on 2018-03-16

OperationSmiley: Corrected shadowing of local variables

Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa

a27e59f... by Armin Le Grand <<email address hidden> (CIB)> on 2018-03-16

OperationSmiley: Removed unused param from SdrPathObj constructor

Change-Id: Ia69e822c698ea13650d868472ba63744727ff886

642864b... by Armin Le Grand <<email address hidden> (CIB)> on 2018-03-15

OperationSmiley: Secured quite some places using CustomShape

Changed quite some places of SdrObjCustomShape usage to use
references instead of pointers, thus forcing to more secure
handling. Changed some test and change methods, even found a
memory leak by doing so.
Added some incudes/predefines for linux builds.

Change-Id: Iba76037a3c54af50bb05e6bd63d7ad04624665a7

2855ffa... by Armin Le Grand <<email address hidden> (CIB)> on 2018-03-15

OperationSmiley: Secured quite some places using CustomShape

Changed quite some places of SdrObjCustomShape usage to use
references instead of pointers, thus forcing to more secure
handling. Changed some test and change methods, even found a
memory leak by doing so.

Change-Id: Iba76037a3c54af50bb05e6bd63d7ad04624665a7

66383e6... by Armin Le Grand <<email address hidden> (CIB)> on 2018-02-23

OperationSmiley: Added support for using same FillGeometry

It is now possible to use a single FillGeometry to fill objects that
are made of multiple filled objects (e.g. CustomShapes) so that
they look as using a single fill. This is used for CustomShapes,
but may later be 'extended' to be used for more cases. The basic
functionality was already in the primitives, but had to be added
to SDrObject due to these being used for CustomShapeVisualization
(currently - would be better to change this to primitives, too).

Change-Id: I1d9fb158191a9ec663e46f3911213be2f3d88986

98646c0... by Armin Le Grand <<email address hidden> (CIB)> on 2018-02-22

OperationSmiley: Remove brightness from SdrPathObj

There was a member at SdrPathObj called mdBrightness only for
holding a blend value during creation of SdrPathObjs for
CustomShape visualization. This has nothing to do on the
model data, move it to where it belongs

Change-Id: Iee101f90a1275ce1ed97e8e8d0ccf7084c83d4f6

4b2d899... by Noel Grandin <email address hidden> on 2018-01-19

loplugin:unused-returns in sc

Change-Id: Ic1d6cbf883fcfeb013c3a82d31c177a1a14bb7c8
Reviewed-on: https://gerrit.libreoffice.org/48193
Reviewed-by: Eike Rathke <email address hidden>
Tested-by: Jenkins <email address hidden>

fd5e480... by Eike Rathke on 2018-03-15

Check return of ScFlatBoolRowSegments::ForwardIterator::getValue()

And if it is only an assert() where code (probably rightly)
assumed there is a value.. if there wasn't then we'll have to
handle it.

Change-Id: Icbdb4a7727ca4cf8a6372c03e02d3bffa6156b6c
Reviewed-on: https://gerrit.libreoffice.org/51374
Reviewed-by: Eike Rathke <email address hidden>
Tested-by: Jenkins <email address hidden>