Merge lp:~doctormo/python-snippets/lp-merge-request-example into lp:~jonobacon/python-snippets/trunk

[Martin Owens]

[Martin Owens (doctormo)]

Added in a new merge request example... which I'm using to submit this merge request.

[Jono Bacon (jonobacon)]

I am getting an error, Martin:

jono@forge:~/source/bzr/python-snippets/launchpadlib$ python merge-request.py
Traceback (most recent call last):
  File "merge-request.py", line 11, in <module>
    os.makedir(CACHE_DIR)
AttributeError: 'module' object has no attribute 'makedir'

Could you take a look and fix?

Also, the snippet does not have the meta-data required, see https://wiki.ubuntu.com/PythonSnippets for details. :-)

[Jono Bacon (jonobacon)]

review: Needs Fixing

[Martin Owens (doctormo)]

Updated with a fix.

review: Needs Resubmitting

[lp:~doctormo/python-snippets/lp-merge-request-example]

21. By Martin Owens on 2010-02-06

Fix the make directory line.

[Jono Bacon (jonobacon)]

Still getting problems, and still no meta data at the top.

jono@forge:~/source/bzr/python-snippets/launchpadlib$ python merge-request.py
Traceback (most recent call last):
  File "merge-request.py", line 14, in <module>
    lp = Launchpad.login_with("python-snippets", STAGING_SERVICE_ROOT)
  File "/usr/lib/pymodules/python2.6/launchpadlib/launchpad.py", line 243, in login_with
    timeout=timeout, proxy_info=proxy_info)
  File "/usr/lib/pymodules/python2.6/launchpadlib/launchpad.py", line 99, in __init__
    credentials, service_root, cache, timeout, proxy_info)
  File "/usr/lib/pymodules/python2.6/lazr/restfulclient/resource.py", line 394, in __init__
    self._wadl = self._browser.get_wadl_application(self._root_uri)
  File "/usr/lib/pymodules/python2.6/lazr/restfulclient/_browser.py", line 241, in get_wadl_application
    url, media_type=wadl_type, extra_headers={'Accept': accept})
  File "/usr/lib/pymodules/python2.6/lazr/restfulclient/_browser.py", line 217, in _request
    raise HTTPError(response, content)
lazr.restfulclient.errors.HTTPError: HTTP Error 401: Unauthorized
Response headers:
---
content-length: 44
content-type: text/plain
date: Sat, 06 Feb 2010 22:51:56 GMT
server: zope.server.http (HTTP)
status: 401
via: 1.1 wildcard.staging.launchpad.net
x-lazr-oopsid: OOPS-1498S207
x-powered-by: Zope (www.zope.org), Python (www.python.org)
---
Response body:
---
Unknown access token (tCLqh00lwH8ZRT5rzXd5).
---

jono@forge:~/source/bzr/python-snippets/launchpadlib$

review: Needs Fixing

[Tim Penhey (thumper)]

Martin, the Resubmit review isn't normally for you to say it is done, but for a reviewer to say that they think you have completely the wrong idea. Perhaps we should document this better.

Unmerged revisions

21. By Martin Owens on 2010-02-06

Fix the make directory line.

20. By Martin Owens on 2010-01-29

Add in new merge request example.

=== added file 'launchpadlib/merge-request.py'
--- launchpadlib/merge-request.py	1970-01-01 00:00:00 +0000
+++ launchpadlib/merge-request.py	2010-02-06 21:59:10 +0000
@@ -0,0 +1,30 @@
+# Code by Martin Owens, (c) 2010 GPLv3
+
+import os
+import time
+from launchpadlib.launchpad import Launchpad, STAGING_SERVICE_ROOT
+from launchpadlib.credentials import Credentials
+
+CACHE_DIR = os.path.expanduser('~/.cache/launchpadlib/')
+
+if not os.path.exists(CACHE_DIR):
+    os.mkdir(CACHE_DIR)
+
+# connect ot the staging service of launchpad
+lp = Launchpad.login_with("python-snippets", STAGING_SERVICE_ROOT)
+
+branch = lp.branches.getByUniqueName(unique_name='lp:~foo/bar/child')
+parent = lp.branches.getByUniqueName(unique_name='lp:~foo/bar/parent')
+
+reviewer  = parent.reviewer
+if not reviewer:
+    reviewer = parent.owner
+
+result = self.source_branch.createMergeProposal(
+    initial_comment=comment,
+    needs_review=True,
+    target_branch=parent,
+    reviewers=(reviewer),
+    review_types=('')
+)
+