Merge lp:~docky-core/plank/keybindings into lp:plank

[Rico Tzschichholz]

Add keybindings support

Still considered work-in-progress!
* It is probably better to disable this feature by default.
* Add settings UI changes
* Support bindings for more than 10 items
* Don't stop events with "modifiers" only

[lp:~docky-core/plank/keybindings]

1310. By Rico Tzschichholz on 2015-06-07

drawing: Use Gtk.IconTheme in a thread-safe way

1311. By Rico Tzschichholz on 2015-06-08

lib: Avoid some superfluous string-copying

1312. By Rico Tzschichholz on 2015-06-08

dockitem: Add the "surface == null" surface-status

1313. By Rico Tzschichholz on 2015-06-08

logger: Partial rewrite, with strip down to the "nearly" bare minimum

1314. By Rico Tzschichholz on 2015-06-08

worker: Make ThreadPool non-exclusive and use GLib.get_num_processors()

1315. By Rico Tzschichholz on 2015-06-08

filedockitem: Drop unused code

1316. By Rico Tzschichholz on 2015-06-08

build: Fix make distcheck

1317. By Rico Tzschichholz on 2015-06-09

drawingservice: Use string-array directly and don't copy to Gee.ArrayList

1318. By Rico Tzschichholz on 2015-06-10

po: Update translations

1319. By Rico Tzschichholz on 2015-06-10

src: Use more reasonable class-name and namespace-structure

1320. By Rico Tzschichholz on 2015-06-10

renderer: Schedule unhide-on-start callback "as late as possible"

1321. By Rico Tzschichholz on 2015-06-10

dockitem: Schedule icon-theme-changed callback "as late as possible"

1322. By Rico Tzschichholz on 2015-06-10

drawingservice: Make icon_theme creation thread-safe

1323. By Rico Tzschichholz on 2015-06-10

renderer: Move frame-time handling into AnimatedRenderer

Make AnimatedRenderer-class responsible to perform and schedule redraws.

1324. By Rico Tzschichholz on 2015-06-10

animatedrenderer: Use Gdk.FrameClock to determine frame-time

Conditionally use Gdk.FrameClock if Gtk+ >= 3.8 is available

1325. By Rico Tzschichholz on 2015-06-10

Revert "items: Use threaded icon-drawing for all items"

Too unstable for being usable!

1326. By Rico Tzschichholz on 2015-06-11

Add RTL support and enable it depending on the locale setting

Reverse items placement.
Mirror position for vertical docks.
Invert alignments for horizonzal docks.
Mirror badge and progress-bar.

1327. By Rico Tzschichholz on 2015-06-17

po: Update translations

1328. By Rico Tzschichholz on 2015-06-27

animatedrenderer: Always initialize frame if a redraw is scheduled

1329. By Rico Tzschichholz on 2015-06-27

po: Update translations

1330. By Rico Tzschichholz on 2015-07-03

dockrenderer: Guard duration-calculations which are used for animations

1331. By Rico Tzschichholz on 2015-07-06

Update symbols

1332. By Rico Tzschichholz on 2015-07-09

color: Avoid double setting of out-vars in hsv_to_rgb

1333. By Rico Tzschichholz on 2015-07-09

color: Clarify documention of set_min/max_* methods

1334. By Rico Tzschichholz on 2015-07-09

hidemanager: Add dodge-active hide-mode

1335. By Rico Tzschichholz on 2015-07-12

prefswindow: Use Gtk.Stack if available

1336. By Rico Tzschichholz on 2015-06-14

build: Drop dependency on gnome-common

1337. By Rico Tzschichholz on 2015-07-12

prefswindow: Allow closing the window using "Escape"

1338. By Rico Tzschichholz on 2015-07-12

po: Update translations

1339. By Rico Tzschichholz on 2015-07-12

ui: Tweak minimum gtk+ version for conditional 3.4 support

1340. By Rico Tzschichholz on 2015-07-15

build: Make sure to enable maintainer-mode by default

1341. By Rico Tzschichholz on 2015-06-27

Add icon-zoom preferences and expose gui-settings

1342. By Rico Tzschichholz on 2015-07-02

Add optional zoom animation when hovering dock-items

1343. By Rico Tzschichholz on 2015-07-16

Add ability to cache multiple sizes of drawn items

1344. By Rico Tzschichholz on 2015-07-16

Update symbols

1345. By Rico Tzschichholz on 2015-07-16

po: Update translation template

1346. By Rico Tzschichholz on 2015-07-16

surfacecache: Add missing mutex-unlock

1347. By Rico Tzschichholz on 2015-07-20

po: Update translations

1348. By Rico Tzschichholz on 2015-07-20

lib: Make sure to bind "plank" textdomain for library users

1349. By Rico Tzschichholz on 2015-07-20

lib: Replace non-constant string-concatenation with string.printf()

1350. By Rico Tzschichholz on 2015-07-25

appdockitem: Always indicate running application despite its window-count

1351. By Rico Tzschichholz on 2015-07-25

tests: Add google-mock support

1352. By kay van der Zander on 2015-07-25

gmock: Add tests for Color

1353. By Rico Tzschichholz on 2015-07-28

hidemanager: Rework enter/leave-event handling to determine "Hovered"

This removes handling of send_event and use "Disabled" for visible menu.

1354. By Rico Tzschichholz on 2015-07-28

po: Update translations

1355. By Rico Tzschichholz on 2015-07-28

ui: Fix "Icon Zoom" label spanning

1356. By Rico Tzschichholz on 2015-07-28

dockwindow: Reinstate "handling of send_event" to fix broken internal DnD

Regression of r1353

1357. By Rico Tzschichholz on 2015-07-28

surfacecache: Fix build with gee-1.0

1358. By Rico Tzschichholz on 2015-07-29

dockcontainer: Update element's RemoveTime on add/replace accordingly

1359. By Rico Tzschichholz on 2015-07-30

lib: Commonize naming of fields which are holding handler/timer-ids

Adjust some explictly typed assignments too.

1360. By Rico Tzschichholz on 2015-07-30

dockrenderer: Use animated_draw() and don't listen to HoveredItem changes

1361. By Rico Tzschichholz on 2015-07-30

dockrenderer: Do not forcefully unhide the dock if it already is

If we do it will cause the dock to hide and unhide again on startup.

1362. By Rico Tzschichholz on 2015-07-30

Revert "dockrenderer: Use animated_draw() and don't listen to HoveredItem changes"

1363. By Rico Tzschichholz on 2015-07-30

positionmanager: Make item's background-region always cover dock's background from bottom up

1364. By Rico Tzschichholz on 2015-08-12

po: Update translations

1365. By Rico Tzschichholz on 2015-08-13

hidemanager: Don't use actual cursor coords of leave-notify-event

If we received a leave-notify-event then don't be silly and make sure
update_hovered_with_coords() will set Hovered to false by passing
(-1, -1).

1366. By Rico Tzschichholz on 2015-08-13

hidemanager: Reinstate "handling of send_event" to avoid confusion with menu

Regression of r1353

1367. By Rico Tzschichholz on 2015-08-14

dockrenderer: Output the Cairo.SurfaceType used by Gtk+

1368. By Rico Tzschichholz on 2015-08-17

positionmanager: Fix background-size calculation with enabled icon-zoom

We need to take the zoomed icon-size into account to properly adjust the
horizontal padding for the background-sizing while differentiating
between first and last item.

1369. By xapantu on 2015-08-19

hidemanager: Ignore pressure-reveal for 'absolute' input-devices

1370. By Rico Tzschichholz on 2015-08-20

dockelement: Make using -Werror=pointer-to-int-cast pass

1371. By Rico Tzschichholz on 2015-08-20

dockwindow: Make using -Werror=unused-result pass

1372. By Rico Tzschichholz on 2015-08-21

dockrenderer: Adjust shadow-size if window-scale-factor > 1 aka HiDPI

1373. By Rico Tzschichholz on 2015-08-22

po: Update translations

1374. By Rico Tzschichholz on 2015-08-23

lib: Cast some callbacks to avoid the creation of wrappers

1375. By Rico Tzschichholz on 2015-08-23

build: Require cairo >= 1.10

1376. By Rico Tzschichholz on 2015-08-23

lib: Cast some callbacks to avoid the creation of wrappers

1377. By Rico Tzschichholz on 2015-08-23

dbusmanager: Fix naming of fields which are holding handler/timer-ids

1378. By Rico Tzschichholz on 2015-08-23

dockrenderer: Avoid usage of Cairo.SurfaceType.COGL

1379. By Rico Tzschichholz on 2015-08-23

build: Clean bamf/gtk+ version check

1380. By Rico Tzschichholz on 2015-08-24

itemfactory: Make get_launcher_from_dockitem() a bit more safer/verbose

1381. By Rico Tzschichholz on 2015-09-03

dockcontainer: Add remove_all()

1382. By Rico Tzschichholz on 2015-09-03

dockrenderer: Guard against empty dock (which ideally won't happen)

1383. By Rico Tzschichholz on 2015-09-03

dockcontroller: Clean out old default-provider after replacing it

1384. By Rico Tzschichholz on 2015-09-03

dockcontainer: Optimize prepend()

1385. By Rico Tzschichholz on 2015-09-07

po: Update translations

1386. By Rico Tzschichholz on 2015-09-07

itemfactory: Avoid a string-copying

1387. By Rico Tzschichholz on 2015-09-07

positionmanager: Demote criticals of get_draw_value_for_item() to debug/warning

1388. By Rico Tzschichholz on 2015-09-07

Prepare 0.10.0 release

1389. By Rico Tzschichholz on 2015-09-07

Back to development

1390. By Mike Gabriel on 2015-09-09

animatedrenderer: Fix typo in error message

1391. By Rico Tzschichholz on 2015-09-10

build: Require valac >= 0.24.0 and obsolete conditionals

1392. By Rico Tzschichholz on 2015-09-16

po: Update translations

1393. By Rico Tzschichholz on 2015-09-28

po: Update translations

1394. By Rico Tzschichholz on 2015-10-01

filedockitem: Correctly display filenames with underscores in folder-menu

1395. By Rico Tzschichholz on 2015-10-01

positionmanager: Just return primary_monitor if empty plug_name was given

1396. By Rico Tzschichholz on 2015-10-01

positionmanager: Add verbose output for monitor_geo_changed

1397. By Rico Tzschichholz on 2015-10-06

dockitemprovider: Insert items where the data was dropped

If there is currently no HoveredItem try to determine the nearest one as
drop-point.

1398. By Rico Tzschichholz on 2015-10-07

lib: Tweak method signature of file-monitor callbacks

1399. By Rico Tzschichholz on 2015-10-07

lib: FileMonitorEvent is a simple enum not a flag

1400. By Rico Tzschichholz on 2015-10-07

lib: Avoid some superfluous reference-taking

1401. By Rico Tzschichholz on 2015-10-07

plankdockitem: Open "preferences" on left-click instead of "about"

1402. By Rico Tzschichholz on 2015-10-08

defaultappprovider: Don't ignore opened applications if Wnck doesn't know

Better don't rely on Wnck if Bamf reported an opened application. If an
application is for whatever reason replacing or renaming its window on
startup we might drop it while Wnck reports a window-count of 0.

1403. By Rico Tzschichholz on 2015-10-08

transientdockitem: Delayed reloading of the window-icon if needed

If the window-icon was null on the first try then schedule a 2nd one.

1404. By Rico Tzschichholz on 2015-10-09

lib: Actually pass e.g. -lm to the linker by adding it to *_LIBADD

1405. By Rico Tzschichholz on 2015-10-09

po: Update translations

1406. By Rico Tzschichholz on 2015-10-09

Prepare 0.10.1 release

1407. By Rico Tzschichholz on 2015-10-19

Back to development

1408. By Rico Tzschichholz on 2015-10-19

build: Be more rebust for parallel building

1409. By Rico Tzschichholz on 2015-10-19

dockrenderer: Don't request a redraw if "transient_items" is empty

1410. By Rico Tzschichholz on 2015-10-31

dockrenderer: Use non-linear transition in/out the "zoom" state

Increase transition-time to 200ms and use cubic-easing.

1411. By Rico Tzschichholz on 2015-10-31

easing: Some optimization, avoid vala's struct-copying by using pointers

1412. By Rico Tzschichholz on 2015-10-31

build: Be more rebust for parallel building

1413. By Rico Tzschichholz on 2015-11-01

easing: Use proper codestyle for ANIMATION_MODES while it is a const

1414. By Rico Tzschichholz on 2015-11-01

dockrenderer: Factor out jump-calculation into easing_bounce

1415. By Rico Tzschichholz on 2015-11-01

dockrenderer: Define and use some internal constants

1416. By Rico Tzschichholz on 2015-11-02

po: Update translations

1417. By Rico Tzschichholz on 2015-11-02

Add docklets support (internal/private)

Based on initially proposed docky 3.0 branch

1418. By Rico Tzschichholz on 2015-11-02

Add GSettings support and transition DockPreferences to it

1419. By Rico Tzschichholz on 2015-11-02

Update symbols

1420. By Rico Tzschichholz on 2015-11-02

po: Don't translate gschema for now

1421. By Rico Tzschichholz on 2015-11-03

Drop nested namespaces

1422. By Rico Tzschichholz on 2015-11-03

Rename DockSurface to Surface

1423. By Rico Tzschichholz on 2015-11-03

Rename AnimatedRenderer to Renderer

1424. By Rico Tzschichholz on 2015-11-03

build: Bump api and library version

1425. By Rico Tzschichholz on 2015-11-03

Keep existing theme and dockitem-files working and update them

1426. By Rico Tzschichholz on 2015-11-03

Update NEWS

1427. By Rico Tzschichholz on 2015-11-03

dockitem: Remove merge-conflict cruft

1428. By Danielle Foré on 2015-11-05

data: Improve strings of GSettings schema

1430. By Rico Tzschichholz on 2015-11-07

settings: Use unowned var and avoid ref'ing in loop

1431. By Rico Tzschichholz on 2015-11-06

docklets: Move to public API

1432. By Rico Tzschichholz on 2015-11-07

docklets: Make Docklet an interface and do follow up changes

1433. By Rico Tzschichholz on 2015-11-08

Add non-functional docklets-gui

1434. By Rico Tzschichholz on 2015-11-08

docs: Fix build

1435. By Rico Tzschichholz on 2015-11-08

build: Fix make distcheck

1436. By Rico Tzschichholz on 2015-11-08

tests: Set PLANK_DOCKLET_DIRS to docklets builddir for test-environment

1437. By Rico Tzschichholz on 2015-11-08

build: Add "run" target for conveniently running plank uninstalled

So running "make run" from the top_builddir will start the just built
plank with the required environment variables to actually pick things up
from the current builddir.

1438. By Rico Tzschichholz on 2015-11-10

services: Don't leak array-container of ObjectClass.list_properties()

ObjectClass.list_properties() transfers the container which needs to be
freed. If valac 0.26 is availble this can be managed.

1439. By Rico Tzschichholz on 2015-11-10

preferences: Cache various strings to avoid retrieving them several times

1440. By Rico Tzschichholz on 2015-11-10

settings: Cache class-type-name string

1441. By Rico Tzschichholz on 2015-11-10

tests: Make sure to use "test1" as dock-name

1442. By Rico Tzschichholz on 2015-11-11

dockitem: Don't leak array-container of ObjectClass.list_properties()

1443. By Rico Tzschichholz on 2015-11-14

Add methods to check some desktop environment types

1444. By Rico Tzschichholz on 2015-11-14

trash: Implement perform_empty_trash()

Only try using Nautilus on "GNOME" and "Unity" enviroments

1445. By Rico Tzschichholz on 2015-11-16

theme: Add "CascadeHide" option

If true it will cause background and icons to unhide/hide with different
speeds so they will leave/hit the screen-edge at the same time.

1446. By Rico Tzschichholz on 2015-11-19

po: Update translations

1447. By Rico Tzschichholz on 2015-11-19

dragmanager: Don't grab input and abort this drag if DragItem is null

1448. By Rico Tzschichholz on 2015-11-30

dockwindow: Be more persuasive to get the window where is should be

1449. By Rico Tzschichholz on 2015-12-02

po: Update translations

1450. By Rico Tzschichholz on 2015-12-04

Use fixed ObjectClass.list_properties() of valac 0.31/32 if available

1451. By Rico Tzschichholz on 2015-12-05

dockitem: Actually use internal constant ITEM_INVALID_DURATION

1452. By Rico Tzschichholz on 2015-12-05

po: Make use of "translator-credits" for Gtk.AboutDialog

1453. By Rico Tzschichholz on 2015-12-06

po: Update translations

1454. By Rico Tzschichholz on 2015-12-07

lib: Add internal compatibility wrapper for gtk+ 3.19.1+

1455. By Rico Tzschichholz on 2015-12-07

widgets: Adjust custom widgets for gtk+ 3.19.1+

1456. By Rico Tzschichholz on 2015-12-07

theme: Create and use custom Gtk.StyleContext

1457. By Rico Tzschichholz on 2015-12-07

dragmanager: Better handling if the actual selection-data is null

1458. By Rico Tzschichholz on 2015-12-07

dockitem: Only use file-monitor for "file://"-icon-files

1459. By Rico Tzschichholz on 2015-12-07

build: Add "run-debug" target for running plank uninstalled within gdb

1460. By Rico Tzschichholz on 2015-12-08

lib: Move HoverWindow instance into DockController

1461. By Rico Tzschichholz on 2015-12-09

dragmanager: Show descriptive tooltip on external-dnd actions

1462. By Rico Tzschichholz on 2015-12-09

dragmanager: desktop-files are special and deserve the drop-to-dock text

1463. By Rico Tzschichholz on 2015-12-11

po: Update translations

1464. By Rico Tzschichholz on 2015-12-11

po: Update translations

1465. By Rico Tzschichholz on 2015-12-22

data: Update appdata to 0.6+ format

1466. By Rico Tzschichholz on 2015-12-22

appdata: Make "summary" translatable, re-use tweaked desktop-file comment

1467. By Rico Tzschichholz on 2015-12-22

po: Update translations

1468. By Rico Tzschichholz on 2016-01-02

Welcome to 2016

1469. By Rico Tzschichholz on 2016-01-03

Use clamp() instead of min(max())

1470. By Rico Tzschichholz on 2016-01-03

dockpreferences: No need to notify about external changes of DockItems

1471. By Rico Tzschichholz on 2016-01-03

dockcontroller: Serialize possible DockItems change on start-up

1472. By Rico Tzschichholz on 2016-01-03

dockcontroller: Fix r1471 and actually save DockItems change on start-up

1473. By Rico Tzschichholz on 2016-01-04

color: Fix mess-up of r1469

1474. By Rico Tzschichholz on 2016-01-04

filedockitem: Hide "Keep in Dock" wile LockItems is enabled

1475. By Rico Tzschichholz on 2016-01-05

po: Update translations

1476. By Rico Tzschichholz on 2016-01-06

dockrenderer: Don't apply window-scale-factor twice on foreground-icon-size

Regression of r1343

1477. By Rico Tzschichholz on 2016-01-07

applicationdockitem: Check LauncherEntry values for actual changes

Also restrict the precision of "progress".

1478. By Rico Tzschichholz on 2016-01-07

items: Reduce redraw requests on LauncherEntry updates

1479. By Rico Tzschichholz on 2016-01-07

items: Fix build without dbusmenu-glib

1480. By Rico Tzschichholz on 2016-01-07

unity: Handle bad LauncherAPI clients which have an insane update-rate

Skip/hold requests if they are arriving within a defined threshold of
32ms after the previous one.

This avoids plank to freeze while not being able to handle all requests.

1481. By Rico Tzschichholz on 2016-01-09

positionmanager: Expand dock on external-drag without enabled zoom too

Also try harder to insert dropped elements at the actually desired spot.

1482. By Rico Tzschichholz on 2016-01-14

unity: Allow a specific amount of fast-updates before skipping/delaying

Cope with applications which are firing update-requests for multiple
application-uris at the same time.

1483. By Rico Tzschichholz on 2016-01-14

Revert "dockpreferences: No need to notify about external changes of DockItems"

This breaks GLib.Settings.bind() so that DockItems never get saved.

1484. By Rico Tzschichholz on 2016-01-14

Allow and handle uris with "docklet" scheme

1485. By Rico Tzschichholz on 2016-01-14

tests: Drop PreferencesWindow test

1486. By Rico Tzschichholz on 2016-01-14

Add some functionality to docklets GUI

Drag'n'drop or double-click a docklet to add it.

1487. By Rico Tzschichholz on 2016-01-14

settings: Must take reference of matched ParamSpec

Not doing so results in an undefined behaviour while things ran out of
scope when calling GSettings.bind().

This reverts r1430

1488. By Rico Tzschichholz on 2016-01-14

build: Fix gtk+-3.0 < 3.10 (non-HiDPI)

1489. By Rico Tzschichholz on 2016-01-26

preferenceswindow: Allow changing the backing DockController

1490. By Rico Tzschichholz on 2016-01-30

unity: Expose API to handle LauncherEntry DBus clients

1491. By Rico Tzschichholz on 2016-01-30

po: Update translations

1492. By Rico Tzschichholz on 2016-01-30

Cast callbacks to GLib.SourceFunc where possible

1493. By Rico Tzschichholz on 2016-02-01

unity: Use the real sender-name given by NameOwnerChanged

1494. By Rico Tzschichholz on 2016-02-02

build: Add autogen.sh to tarball

Conveniently rebuild/update the autotools downstream.

1495. By Rico Tzschichholz on 2016-02-07

po: Update translations

1496. By Rico Tzschichholz on 2016-02-13

examples: Add UnityClient example

1497. By Rico Tzschichholz on 2016-02-15

abstractmain: Use new GLib.Application commandline handling API

Require glib >= 2.40

1498. By Rico Tzschichholz on 2016-02-15

build: Drop support for gee-1.0

1499. By Rico Tzschichholz on 2016-02-15

build: Drop obsololete glib conditionals and bump vala's target-glib

1500. By Rico Tzschichholz on 2016-02-15

build: Drop support for gtk+ < 3.10

1501. By Rico Tzschichholz on 2016-02-16

ui: Use valac's gtktemplate support

1502. By Rico Tzschichholz on 2016-02-16

po: Update translations

1503. By Rico Tzschichholz on 2016-02-16

lib: Update symbols

1504. By Rico Tzschichholz on 2016-02-16

build: Only cairo >= 1.13 is required for HiDPI

1505. By Rico Tzschichholz on 2016-02-16

tests: Make sure to quit "dock" test application

1506. By Rico Tzschichholz on 2016-02-17

preferenceswindow: Keep translated "Preferences" string around for now

1507. By Rico Tzschichholz on 2016-02-17

docktheme: Adjust draw-position item-badge to avoid cropped shadow

1508. By Rico Tzschichholz on 2016-02-20

positionmanager: Partly restore original icon-zoom

1509. By Rico Tzschichholz on 2016-02-21

dockitem: Handle file-monitor event where current launcher was target

If "other" of FileMonitorEvent.MOVED matches our current launcher-file
than it got replaced by a new file, so avoid doing anything other than
loading possible new information.

1510. By Rico Tzschichholz on 2016-02-22

items: Handle "PinnedOnly" in DefaultApplicationDockItemProvider

This is more efficient than doing this in the DockController. Only the
actually effected items are created/purged on a settings change.

1511. By Rico Tzschichholz on 2016-02-22

factories: Generalize "dockitem-file" loader

1512. By Rico Tzschichholz on 2016-02-22

items: Add LauncherEntry's transient-items only if allowed

Regression of r1510

1513. By Rico Tzschichholz on 2016-02-22

Add "simple and experimental" multi-dock support

Running multiple concurrent instances while using "-n|--name"
is still possible.

There are no exposed GUI controls, therefore the newly added
"enabled-docks" settings-key should be used.

1514. By Rico Tzschichholz on 2016-02-22

items: Add transient-items only if allowed

1515. By Rico Tzschichholz on 2016-02-22

Update NEWS

1516. By Rico Tzschichholz on 2016-02-22

po: Update translations

1517. By Rico Tzschichholz on 2016-02-22

utils: Add internal create_settings() and try_create_settings()

... and make use of them where possible.

1518. By Rico Tzschichholz on 2016-02-22

utils: Add internal string_split_combine()

1519. By Rico Tzschichholz on 2016-02-22

utils: Add internal file_is_dockitem()

1520. By Rico Tzschichholz on 2016-02-22

settings: Allow to specify gsetting's bind-flags

1521. By Rico Tzschichholz on 2016-02-23

Follow the environment's setting whether to show notifications or not

If false, urgent-bounce and urgent-glow animations are disabled.

1522. By Rico Tzschichholz on 2016-02-23

lib: Move DockItemDrawValue and its dependencies to top-level namespace

1523. By Rico Tzschichholz on 2016-02-23

docs: Fix build

1524. By Rico Tzschichholz on 2016-02-25

controller: If the item-count has changed do a more thorough size-update

1525. By Rico Tzschichholz on 2016-02-25

positionmanager: Drop redundant call of update_regions()

1526. By Rico Tzschichholz on 2016-02-25

surfacecache: Force allow-downscale if drawing-time is insanely high

If drawing-time of a single surface exceeds a certains limit (30ms) and
"flags" is NONE then set ALLOW_DOWNSCALE to make it less demanding.

Also mark the created surface, so the DockRenderer can try to ease things
out for later draw requests.

1527. By Rico Tzschichholz on 2016-02-28

services: Rename internal Offsettings to EnvironmentSettings

1528. By Rico Tzschichholz on 2016-02-28

Check existence of keys in 3rd-party GSchemas before using them

Accessing a non-existing key is a fatal error for GSettings.

1529. By Rico Tzschichholz on 2016-02-28

po: Update translations

1530. By Rico Tzschichholz on 2016-03-04

prefs: Add TooltipsEnabled setting

This controls whether to show tooltips on hovering items with the cursor.
Tooltips showing up to descibe ongoing DnD-actions are not impacted.

It is enabled by default.

1531. By Rico Tzschichholz on 2016-03-08

hidemanager: TOUCHPAD devices are able to perform pressure on a barrier

1532. By Rico Tzschichholz on 2016-03-09

preferenceswindow: Hide "auto-pinning" setting

1533. By Rico Tzschichholz on 2016-03-09

preferenceswindow: Hide "show-dock-item" setting

Make "show-dock-item" default to false

1534. By Rico Tzschichholz on 2016-03-12

data: Some tweaking of the default themes

1535. By Rico Tzschichholz on 2016-03-12

Update README

1536. By Rico Tzschichholz on 2016-03-12

Update NEWS

1537. By Rico Tzschichholz on 2016-03-12

Prepare 0.11.0 release

1538. By Rico Tzschichholz on 2016-03-22

Back to development

1539. By Rico Tzschichholz on 2016-03-22

system: Use DesktopAppInfo.from_filename() to set desktop-filename

If the filename property is not set then an empty string will be send out
via org.gtk.gio.DesktopAppInfo rather than the proper desktop-filename
that we actually have. This is used for startup-notifications by Bamf.

1540. By Rico Tzschichholz on 2016-03-22

po: Update translations

1541. By Rico Tzschichholz on 2016-03-22

dockletmanager: Only handle properly named docklet-libraries

1542. By Rico Tzschichholz on 2016-03-23

controller: Actually emmit elements_changed() to make DBusClient work

1543. By Rico Tzschichholz on 2016-03-23

vapi: Sync libbamf3.vapi with 0.5.3~bzr0+16.04.20160322.1-0ubuntu1

1544. By Rico Tzschichholz on 2016-03-25

applicationdockitem: Force indicator-update if running-state changed

1545. By Rico Tzschichholz on 2016-03-29

applicationdockitem: Use child-* signals of Bamf.View

The window-* signals are emitted too early and the internal window/xid
caches of Bamf aren't updated yet.

1546. By Rico Tzschichholz on 2016-03-29

po: Update translations

1547. By Rico Tzschichholz on 2016-03-30

Prepare 0.11.1 release

1548. By Rico Tzschichholz on 2016-04-04

Back to development

1549. By Rico Tzschichholz on 2016-04-04

lib: Update symbols

1550. By Rico Tzschichholz on 2016-04-07

surface: Some minor cleaning

1551. By Rico Tzschichholz on 2016-04-10

drawing/color: Add support for HSL and some convenience functions

1552. By Rico Tzschichholz on 2016-05-11

clippy: Pass correct index in menu-item-callback

1553. By Rico Tzschichholz on 2016-05-11

clippy: text parameter of ClipboardTextReceivedFunc is allowed to be null

1554. By Rico Tzschichholz on 2016-05-11

po: Update translations

1555. By Rico Tzschichholz on 2016-05-12

clippy: Need to own the clipboard's content before allowed to clear it

1556. By Rico Tzschichholz on 2016-05-31

po: Update translations

1557. By Rico Tzschichholz on 2016-06-01

build: Require valac >= 0.26.0 and drop obsolete conditionals

1558. By Rico Tzschichholz on 2016-06-01

lib: Use vala's Cairo.Surface.get/set_device_scale() bindings

1559. By Rico Tzschichholz on 2016-06-01

vapi: Drop internal copy of x11.vapi

1560. By Rico Tzschichholz on 2016-06-02

lib: Add and enforce some file-count limits

This is just a safe-guard to prevent plank from "blowing up" if we are
about to handle an unreasonable amount of files.

1561. By Rico Tzschichholz on 2016-06-05

docklets: Fill in some descriptions and not leave them blank

1562. By Rico Tzschichholz on 2016-06-06

Prepare 0.11.2 release

1563. By Rico Tzschichholz on 2016-07-07

Back to development

1564. By Rico Tzschichholz on 2016-07-07

po: Update translations

1565. By Rico Tzschichholz on 2016-08-09

Add CPUMonitor docklet

1566. By Rico Tzschichholz on 2016-08-09

po: Update translations

1567. By Rico Tzschichholz on 2016-08-11

appdata: Add some keywords and translate-url

1568. By Rico Tzschichholz on 2016-09-14

tests: Fix type mismatch

1569. By Rico Tzschichholz on 2016-10-05

clippy: Move generic-typed field initializer to construct

1570. By Rico Tzschichholz on 2016-10-05

po: Update translations

1571. By Rico Tzschichholz on 2016-10-28

surfacecache: Never clear the cache completely

1572. By Rico Tzschichholz on 2016-10-28

po: Update translations

1573. By Rico Tzschichholz on 2016-11-03

Make use of vala's native Regex support where possible

1574. By Rico Tzschichholz on 2016-11-03

vapi: Avoid "Deprecated" warning for libbamf3

1575. By Rico Tzschichholz on 2016-11-04

windows: Hide tooltips if the user performed action on a dockitem

Obviously tooltips will be hidden on appearance of the menu. In addition
to that it will hide on click- and scroll-events too now.

This avoids obstructing maybe important windows parts the user wants to
interact with.

1576. By Rico Tzschichholz on 2016-11-05

appdockitem: Don't over-react on user-visible changes and keep transients

Dropping an running application here is a bit harsh in case of transient
items. If a splashscreen is shown then this bit changes along the
starting process and is fatal for not-pinned items.

1577. By Rico Tzschichholz on 2016-11-05

appdockitem: Trust bamf with providing us the window-count

1578. By Rico Tzschichholz on 2016-11-06

filedockitem: Use the file's display-name where possible

This is the proper string to use for user-visible references to a file.

1579. By Rico Tzschichholz on 2016-11-19

Drop references to gthread-2.0

This is deprecated and obsolete since glib 2.32.0.

1580. By Rico Tzschichholz on 2016-11-20

logger: Reinstate null-check for non-initialized calling

1581. By Rico Tzschichholz on 2016-11-30

unity: Fix spelling error

1582. By Rico Tzschichholz on 2016-12-06

Prepare 0.11.3 release

1583. By Rico Tzschichholz on 2017-01-16

Back to development

1584. By Rico Tzschichholz on 2017-01-16

Welcome to 2017

Unmerged revisions

1586. By Rico Tzschichholz on 2015-06-06

keybindingsmanager: Use gdk_window_add/remove_filter()

1585. By Rico Tzschichholz on 2015-03-25

Add initial support for Keybindings to access items

There is the possiblity to define base-modifier key to trigger
keybindings-overlay and an additional modifier key for optional
item-action. The first 10 items will have an active binding.

=== modified file 'data/net.launchpad.plank.gschema.xml.in.in'
--- data/net.launchpad.plank.gschema.xml.in.in	2016-03-09 08:51:55 +0000
+++ data/net.launchpad.plank.gschema.xml.in.in	2017-01-16 09:48:10 +0000
@@ -71,11 +71,27 @@
 			<_summary>Icon Size</_summary>
 			<_description>The size of dock items, in pixels.</_description>
 		</key>
+		<key name="item-accelerator" type="s">
+			<default>'Super_L'</default>
+			<_summary>The base modifier-key for item keybinding shortcuts</_summary>
+			<_description></_description>
+		</key>
 		<key name="items-alignment" enum='GtkAlignType'>
 			<default>'center'</default>
 			<_summary>The alignment of dock items</_summary>
 			<_description>Possible values are "fill", "start", "end", and "center".</_description>
 		</key>
+		<key name="item-option-accelerator" type="s">
+			<default>'Shift_L'</default>
+			<_summary>The additional modifier-key for optional item keybinding shortcuts</_summary>
+			<_description></_description>
+		</key>
+		<key name="keybinding-unhide-delay" type="i">
+			<range min="0"/>
+			<default>400</default>
+			<_summary>Keybinding unhide delay</_summary>
+			<_description>Length of the delay before showing keybinding-overlay the dock, in milliseconds.</_description>
+		</key>
 		<key name="lock-items" type="b">
 			<default>false</default>
 			<_summary>Lock dock items</_summary>

=== modified file 'lib/DockController.vala'
--- lib/DockController.vala	2016-03-23 19:51:11 +0000
+++ lib/DockController.vala	2017-01-16 09:48:10 +0000
@@ -40,6 +40,7 @@
 		public DockRenderer renderer { get; protected set; }
 		public DockWindow window { get; protected set; }
 		public HoverWindow hover { get; protected set; }
+		public KeybindingManager keybinding_manager { get; protected set; }
 		
 		public DockItemProvider? default_provider { get; private set; }
 		
@@ -100,6 +101,7 @@
 			window = new DockWindow (this);
 			hover = new HoverWindow ();
 			renderer = new DockRenderer (this, window);
+			keybinding_manager = new KeybindingManager (this);
 		}
 		
 		~DockController ()
@@ -140,6 +142,14 @@
 			renderer.initialize ();
 			
 			window.show_all ();
+			
+			// FIXME maybe do this on a separate thread while this takes some time if X is stalling
+			// putting it into an idle at least gives the illusion of starting up fast ;-)
+			Idle.add (() => {
+				keybinding_manager.initialize ();
+				
+				return false;
+			});
 		}
 		
 		/**
@@ -224,6 +234,14 @@
 			}
 		}
 		
+		public void virtual_click_item_at (int pos, PopupButton button)
+		{
+			if (visible_items.size < pos + 1)
+				return;
+			
+			visible_items[pos].clicked (button, 0, Gtk.get_current_event_time ());
+		}
+		
 		protected override void update_visible_elements ()
 		{
 			base.update_visible_elements ();

=== modified file 'lib/DockPreferences.vala'
--- lib/DockPreferences.vala	2016-03-04 15:54:48 +0000
+++ lib/DockPreferences.vala	2017-01-16 09:48:10 +0000
@@ -90,6 +90,15 @@
 		[Description(nick = "tooltips-enabled", blurb = "Whether to show tooltips when items are hovered.")]
 		public bool TooltipsEnabled { get; set; }
 		
+		[Description(nick = "item-accelerator", blurb = "The base modifier-key for item keybinding shortcuts.")]
+		public string ItemAccelerator { get; set; }
+		
+		[Description(nick = "item-option-accelerator", blurb = "The additional modifier-key for optional item keybinding shortcuts.")]
+		public string ItemOptionAccelerator { get; set; }
+		
+		[Description(nick = "keybinding-unhide-delay", blurb = "Time (in ms) to wait before showing keybinding-overlay the dock.")]
+		public uint KeybindingUnhideDelay { get; set; }
+		
 		/**
 		 * {@inheritDoc}
 		 */

=== modified file 'lib/DockRenderer.vala'
--- lib/DockRenderer.vala	2016-06-01 09:48:44 +0000
+++ lib/DockRenderer.vala	2017-01-16 09:48:10 +0000
@@ -29,6 +29,11 @@
 		public DockTheme theme { get; private set; }
 		
 		/**
+		 * If the dock should show the keybindings and which.
+		 */
+		public Keybinding VisibleKeybinding { get; set; default = 0; }
+		
+		/**
 		 * The current progress [0.0..1.0] of the hide-animation of the dock.
 		 */
 		[CCode (notify = false)]
@@ -62,13 +67,16 @@
 		Surface? indicator_buffer = null;
 		Surface? urgent_indicator_buffer = null;
 		Surface? urgent_glow_buffer = null;
+		Gee.HashMap<uint, Surface> keybinding_buffers;
 		
 		int64 last_hide = 0LL;
 		int64 last_hovered_changed = 0LL;
+		int64 last_keybinding = 0LL;
 		
 		bool screen_is_composited = false;
 		bool show_notifications = true;
 		uint reset_position_manager_timer_id = 0U;
+		uint keybindings_timer_id = 0U;
 		int window_scale_factor = 1;
 		bool is_first_frame = true;
 		bool zoom_changed = false;
@@ -98,6 +106,7 @@
 		{
 			transient_items = new Gee.HashSet<DockItem> ();
 			current_items = new Gee.ArrayList<unowned DockItem> ();
+			keybinding_buffers = new Gee.HashMap<uint, Surface> ();
 #if BENCHMARK
 			benchmark = new Gee.ArrayList<string> ();
 #endif
@@ -129,6 +138,46 @@
 			controller.window.notify["HoveredItem"].disconnect (animated_draw);
 		}
 		
+		/**
+		 * Unhide the dock immediately if needed and show keybindings after a short delay
+		 */
+		public void show_keybindings ()
+		{
+			if (keybindings_timer_id > 0U)
+				return;
+			
+			keybindings_timer_id = Timeout.add (controller.prefs.KeybindingUnhideDelay, () => {
+				keybindings_timer_id = 0U;
+				last_keybinding = GLib.get_monotonic_time ();
+				VisibleKeybinding |= Keybinding.ITEMS;
+				
+				animated_draw ();
+				
+				return false;
+			});
+		}
+		
+		/**
+		 * Hide keybindings immediately and hide the dock if needed
+		 */
+		public void hide_keybindings ()
+		{
+			if (keybindings_timer_id > 0U) {
+				Source.remove (keybindings_timer_id);
+				keybindings_timer_id = 0U;
+			}
+			
+			if (VisibleKeybinding != 0) {
+				var now = GLib.get_monotonic_time ();
+				if (now - last_keybinding > controller.prefs.KeybindingUnhideDelay * 1000)
+					last_keybinding = now;
+				
+				VisibleKeybinding = 0;
+			}
+			
+			animated_draw ();
+		}
+		
 		void prefs_changed (Object prefs, ParamSpec prop)
 		{
 			switch (prop.name) {
@@ -213,6 +262,8 @@
 			urgent_indicator_buffer = null;
 			urgent_glow_buffer = null;
 			
+			keybinding_buffers.clear ();
+			
 			animated_draw ();
 		}
 		
@@ -839,6 +890,26 @@
 			// draw indicators
 			if (draw_value.show_indicator && item.Indicator != IndicatorState.NONE)
 				draw_indicator_state (cr, draw_value.hover_region, item.Indicator, item.State);
+			
+			// draw keybinding overlay
+			var keybinding_time = frame_time - last_keybinding;
+			opacity = double.min (1, keybinding_time / (double) (theme.HideTime * 1000));
+			if (VisibleKeybinding == 0)
+				opacity = 1 - opacity;
+			if (opacity > 0) {
+				//FIXME Use letters for for 10+ items
+				var number = (item.Position + 1) % 10;
+				var is_option = ((VisibleKeybinding & Keybinding.ITEMS_OPTION) == Keybinding.ITEMS_OPTION);
+				var index = (is_option ? number + 1024 : number);
+				
+				Surface? keybinding_surface = null;
+				if ((keybinding_surface = keybinding_buffers.get (index)) == null) {
+					keybinding_surface = theme.create_keybinding (icon_size / 2, number.to_string (), item_buffer, is_option);
+					keybinding_buffers.set (index, keybinding_surface);
+				}
+				cr.set_source_surface (keybinding_surface.Internal, draw_region.x + icon_size / 4, draw_region.y + icon_size / 4);
+				cr.paint_with_alpha (opacity);
+			}
 		}
 		
 		void draw_item_shadow (Cairo.Context cr, DockItem item, DockItemDrawValue draw_value)
@@ -1109,6 +1180,9 @@
 					return true;
 			}
 			
+			if (frame_time - last_keybinding <= theme.HideTime * 1000)
+				return true;
+			
 			if (transient_items.size > 0)
 				return true;
 			

=== modified file 'lib/Drawing/DockTheme.vala'
--- lib/Drawing/DockTheme.vala	2016-03-12 15:14:09 +0000
+++ lib/Drawing/DockTheme.vala	2017-01-16 09:48:10 +0000
@@ -276,6 +276,92 @@
 		}
 
 		/**
+		 * Creates a keybinding overlay
+		 *
+		 * @param size the size of the surface
+		 * @param text the string to show
+		 * @param model existing surface to use as basis of new surface
+		 * @param is_option slightly different style for another function
+		 * @return a new dock surface with the keybinding overlay drawn on it
+		 */
+		public Surface create_keybinding (int size, string text, Surface model, bool is_option = false)
+		{
+			Logger.verbose ("DockTheme.create_keybinding (size = %i, text = %s)", size, text);
+			
+			var surface = new Surface.with_surface (size, size, model);
+			surface.clear ();
+			
+			if (size <= 0)
+				return surface;
+			
+			var cr = surface.Context;
+			
+			var line_width = 2.0;
+			var padding = Math.ceil (size / 12.0);
+			double x = line_width / 2.0;
+			double y = line_width / 2.0;
+			double height = size - 2 * line_width;
+			double width = size - 2 * line_width;
+			
+			cr.set_line_width (line_width);
+			
+			Cairo.Pattern stroke, fill;
+			
+			// draw outline shadow
+			stroke = new Cairo.Pattern.rgba (0.2, 0.2, 0.2, 0.3);
+			draw_rounded_line (cr, x, y, width + line_width, height, true, true, stroke, null);
+			
+			// draw filled gradient with outline
+			stroke = new Cairo.Pattern.linear (0, y, 0, y + height);
+			stroke.add_color_stop_rgba (0.2, 0.0, 0.0, 0.0, 0.9);
+			stroke.add_color_stop_rgba (0.8, 0.0, 0.0, 0.0, 0.8);
+			fill = new Cairo.Pattern.linear (0, y, 0, y + height);
+			fill.add_color_stop_rgba (0.1, 0.0, 0.0, 0.0, 0.8);
+			fill.add_color_stop_rgba (0.9, 0.0, 0.0, 0.0, 0.9);
+			draw_rounded_line (cr, x, y, width, height, true, true, stroke, fill);
+			
+			// draw inline highlight
+			if (!is_option)
+				stroke = new Cairo.Pattern.rgba (0.9, 0.9, 0.9, 0.1);
+			else
+				stroke = new Cairo.Pattern.rgba (0.9, 0.9, 0.9, 0.9);
+			draw_rounded_line (cr, x + line_width, y + line_width, width - 2 * line_width, height - 2 * line_width, true, true, stroke, null);
+			
+			var layout = new Pango.Layout (Gdk.pango_context_get ());
+			layout.set_width ((int) (width * Pango.SCALE));
+			layout.set_ellipsize (Pango.EllipsizeMode.NONE);
+			
+			var font_description = new Gtk.Style ().font_desc;
+			font_description.set_absolute_size ((int) (height * Pango.SCALE));
+			font_description.set_weight (Pango.Weight.BOLD);
+			layout.set_font_description (font_description);
+			
+			layout.set_text (text, -1);
+			Pango.Rectangle ink_rect, logical_rect;
+			layout.get_pixel_extents (out ink_rect, out logical_rect);
+			
+			var scale = double.min (1.0, double.min ((width - 2.0 * padding - 2.0 * line_width) / (double) logical_rect.width, (height - 2.0 * padding) / (double) logical_rect.height));
+			
+			cr.set_source_rgba (1.0, 1.0, 1.0, 0.2);
+			
+			cr.move_to (x + Math.floor (width / 2.0 - scale * logical_rect.width / 2.0), y + Math.floor (height / 2.0 - scale * logical_rect.height / 2.0));
+			
+			// draw text
+			cr.save ();
+			if (scale < 1)
+				cr.scale (scale, scale);
+			
+			cr.set_line_width (line_width);
+			Pango.cairo_layout_path (cr, layout);
+			cr.stroke_preserve ();
+			cr.set_source_rgba (1.0, 1.0, 1.0, 0.95);
+			cr.fill ();
+			cr.restore ();
+			
+			return surface;
+		}
+		
+		/**
 		 * Draws an active glow for an item.
 		 *
 		 * @param surface the surface to draw onto

=== modified file 'lib/HideManager.vala'
--- lib/HideManager.vala	2016-03-08 22:15:30 +0000
+++ lib/HideManager.vala	2017-01-16 09:48:10 +0000
@@ -137,6 +137,8 @@
 			unowned DockWindow window = controller.window;
 			unowned Wnck.Screen wnck_screen = Wnck.Screen.get_default ();
 			
+			controller.renderer.notify["VisibleKeybinding"].connect (update_hovered);
+			
 #if HAVE_BARRIERS
 			initialize_barriers_support ();
 #endif
@@ -159,6 +161,7 @@
 			unowned Wnck.Screen wnck_screen = Wnck.Screen.get_default ();
 			
 			controller.prefs.notify.disconnect (prefs_changed);
+			controller.renderer.notify["VisibleKeybinding"].disconnect (update_hovered);
 			
 			window.enter_notify_event.disconnect (handle_enter_notify_event);
 			window.leave_notify_event.disconnect (handle_leave_notify_event);
@@ -215,6 +218,7 @@
 			unowned PositionManager position_manager = controller.position_manager;
 			unowned DockWindow window = controller.window;
 			unowned DragManager drag_manager = controller.drag_manager;
+			unowned DockRenderer renderer = controller.renderer;
 			
 			freeze_notify ();
 			
@@ -233,7 +237,7 @@
 			}
 			
 			// disable hiding if menu is visible or drags are active
-			var disabled = (window.menu_is_visible () || drag_manager.InternalDragActive || drag_manager.ExternalDragActive);
+			var disabled = (window.menu_is_visible () || renderer.VisibleKeybinding > 0 || drag_manager.InternalDragActive || drag_manager.ExternalDragActive);
 			if (Disabled != disabled) {
 				Disabled = disabled;
 				update_needed = true;

=== added file 'lib/KeybindingManager.vala'
--- lib/KeybindingManager.vala	1970-01-01 00:00:00 +0000
+++ lib/KeybindingManager.vala	2017-01-16 09:48:10 +0000
@@ -0,0 +1,405 @@
+//
+//  Copyright (C) 2012 Rico Tzschichholz
+//
+//  This program is free software: you can redistribute it and/or modify
+//  it under the terms of the GNU General Public License as published by
+//  the Free Software Foundation, either version 3 of the License, or
+//  (at your option) any later version.
+//
+//  This program is distributed in the hope that it will be useful,
+//  but WITHOUT ANY WARRANTY; without even the implied warranty of
+//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+//  GNU General Public License for more details.
+//
+//  You should have received a copy of the GNU General Public License
+//  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+//
+
+namespace Plank
+{
+	[Flags]
+	public enum Keybinding {
+		ITEMS = 1 << 0,
+		ITEMS_OPTION = 1 << 1
+	}
+	
+	/**
+	 * This class is in charge to grab keybindings on the X11 display
+	 * and filter X11-events and passing on such events to the registed
+	 * handler methods.
+	 */
+	public class KeybindingManager : GLib.Object
+	{
+		/**
+		 * The controller for this dock.
+		 */
+		public DockController controller { private get; construct; }
+		
+		/**
+		 * list of bound keybindings
+		 */
+		Gee.ArrayList<Binding> bindings = new Gee.ArrayList<Binding> ();
+		
+		/**
+		 * locked modifiers used to grab all keys whatever lock key
+		 * is pressed.
+		 */
+		static uint[] ignored_masks = {
+			0,
+			Gdk.ModifierType.MOD2_MASK, // NUM_LOCK
+			Gdk.ModifierType.LOCK_MASK, // CAPS_LOCK
+			Gdk.ModifierType.MOD5_MASK, // SCROLL_LOCK
+			Gdk.ModifierType.MOD2_MASK | Gdk.ModifierType.LOCK_MASK,
+			Gdk.ModifierType.MOD2_MASK | Gdk.ModifierType.MOD5_MASK,
+			Gdk.ModifierType.LOCK_MASK | Gdk.ModifierType.MOD5_MASK,
+			Gdk.ModifierType.MOD2_MASK | Gdk.ModifierType.LOCK_MASK | Gdk.ModifierType.MOD5_MASK
+		};
+		
+		/**
+		 * Helper class to store keybinding
+		 */
+		class Binding
+		{
+			public string accelerator;
+			public uint8 keycode;
+			public Gdk.ModifierType modifiers;
+			public KeybindingHandlerFunc handler;
+			
+			public Binding (string _accelerator, uint8 _keycode,
+				Gdk.ModifierType _modifiers, owned KeybindingHandlerFunc _handler)
+			{
+				accelerator = _accelerator;
+				keycode = _keycode;
+				modifiers = _modifiers;
+				handler = _handler;
+			}
+		}
+		
+		/**
+		 * Keybinding func needed to bind key to handler
+		 *
+		 * @param event passing on gdk event
+		 */
+		public delegate void KeybindingHandlerFunc (X.Event event);
+		
+		public KeybindingManager (DockController controller)
+		{
+			GLib.Object (controller: controller);
+		}
+		
+		construct
+		{
+			gdk_window_add_filter (null, (Gdk.FilterFunc) xevent_filter);
+		}
+		
+		~KeybindingManager ()
+		{
+			unbind_all ();
+			
+			gdk_window_remove_filter (null, (Gdk.FilterFunc) xevent_filter);
+		}
+		
+		public void initialize ()
+		{
+			var item_accel = controller.prefs.ItemAccelerator;
+			var item_option_accel = controller.prefs.ItemOptionAccelerator;
+			
+			var mod = KeybindingManager.convert_to_modifier_only (item_accel);
+			var option_mod = KeybindingManager.convert_to_modifier_only (item_option_accel);
+			
+			if (controller.prefs.ItemAccelerator == "") {
+				warning ("%s is not a modifier! Keybindings will not be available!", item_accel);
+				return;
+			}
+			
+			// bind base accelerator
+			if (!bind (item_accel, controller.renderer.show_keybindings)
+				|| !bind ("<Release>" + item_accel, controller.renderer.hide_keybindings)) {
+				warning ("Keybindings will not be available!");
+				return;
+			}
+			
+			bind (mod + "1", () => { controller.virtual_click_item_at (0, PopupButton.LEFT); });
+			bind (mod + "2", () => { controller.virtual_click_item_at (1, PopupButton.LEFT); });
+			bind (mod + "3", () => { controller.virtual_click_item_at (2, PopupButton.LEFT); });
+			bind (mod + "4", () => { controller.virtual_click_item_at (3, PopupButton.LEFT); });
+			bind (mod + "5", () => { controller.virtual_click_item_at (4, PopupButton.LEFT); });
+			bind (mod + "6", () => { controller.virtual_click_item_at (5, PopupButton.LEFT); });
+			bind (mod + "7", () => { controller.virtual_click_item_at (6, PopupButton.LEFT); });
+			bind (mod + "8", () => { controller.virtual_click_item_at (7, PopupButton.LEFT); });
+			bind (mod + "9", () => { controller.virtual_click_item_at (8, PopupButton.LEFT); });
+			bind (mod + "0", () => { controller.virtual_click_item_at (9, PopupButton.LEFT); });
+			
+			// bind option accelerator
+			if (item_option_accel == "") {
+				warning ("%s is not a modifier! Optional keybindings will not be available!", item_option_accel);
+				return;
+			}
+			
+			bind (mod + item_option_accel, () => {
+				controller.renderer.VisibleKeybinding |= Keybinding.ITEMS_OPTION;
+				controller.renderer.animated_draw ();
+			});
+			bind ("<Release>" + mod + item_option_accel, () => {
+				controller.renderer.VisibleKeybinding &= ~Keybinding.ITEMS_OPTION;
+				controller.renderer.animated_draw ();
+			});
+			bind ("<Release>" + option_mod + item_option_accel, controller.renderer.hide_keybindings);
+			
+			bind (mod + option_mod + "1", () => { controller.virtual_click_item_at  (0, PopupButton.MIDDLE); });
+			bind (mod + option_mod + "2", () => { controller.virtual_click_item_at  (1, PopupButton.MIDDLE); });
+			bind (mod + option_mod + "3", () => { controller.virtual_click_item_at  (2, PopupButton.MIDDLE); });
+			bind (mod + option_mod + "4", () => { controller.virtual_click_item_at  (3, PopupButton.MIDDLE); });
+			bind (mod + option_mod + "5", () => { controller.virtual_click_item_at  (4, PopupButton.MIDDLE); });
+			bind (mod + option_mod + "6", () => { controller.virtual_click_item_at  (5, PopupButton.MIDDLE); });
+			bind (mod + option_mod + "7", () => { controller.virtual_click_item_at  (6, PopupButton.MIDDLE); });
+			bind (mod + option_mod + "8", () => { controller.virtual_click_item_at  (7, PopupButton.MIDDLE); });
+			bind (mod + option_mod + "9", () => { controller.virtual_click_item_at  (8, PopupButton.MIDDLE); });
+			bind (mod + option_mod + "0", () => { controller.virtual_click_item_at  (9, PopupButton.MIDDLE); });
+		}
+		
+		/**
+		 * Bind accelerator to given handler
+		 *
+		 * @param accelerator accelerator parsable by Gtk.accelerator_parse
+		 * @param handler handler called when given accelerator is pressed
+		 * @return wether the bind was successful or not
+		 */
+		public bool bind (string accelerator, owned KeybindingHandlerFunc handler)
+		{
+			Logger.verbose ("Binding key " + accelerator);
+			
+			// convert accelerator
+			uint keysym;
+			Gdk.ModifierType modmask;
+			Gtk.accelerator_parse (accelerator, out keysym, out modmask);
+			
+			unowned X.Display display = Gdk.X11.get_default_xdisplay ();
+			var xid = Gdk.X11.get_default_root_xwindow ();
+			
+			uint8 keycode = display.keysym_to_keycode (keysym);
+			if (keycode == 0)
+				return false;
+			
+			var keystr = X.keysym_to_string (keysym);
+			if (keystr == null)
+				return false;
+			
+			// FIXME somethings is wrong with the SUPER modifier between the GDK and X values
+			// so replace SUPER_MASK with MOD4_MASK
+			if ((modmask & Gdk.ModifierType.SUPER_MASK) == Gdk.ModifierType.SUPER_MASK)
+				modmask = (modmask & ~Gdk.ModifierType.SUPER_MASK) | Gdk.ModifierType.MOD4_MASK;
+			
+			// trap XErrors to avoid closing of application
+			// even when grabing of key fails
+			Gdk.error_trap_push ();
+			
+			// grab key finally
+			// also grab all keys which are combined with a lock key such NumLock
+			foreach (var ignored_mask in ignored_masks) {
+				Gdk.error_trap_push ();
+				display.grab_key (keycode, modmask | ignored_mask, xid, false, X.GrabMode.Async, X.GrabMode.Async);
+				
+				// wait until all X request have been processed
+				Gdk.flush ();
+				var result = Gdk.error_trap_pop ();
+				if (result != X.ErrorCode.SUCCESS) {
+					warning ("Failed to bind key 0x%X ('%s') with modifiers 0x%X", keycode, keystr, modmask);
+					if (result == X.ErrorCode.BAD_ACCESS)
+						debug ("Some other program is already using the key 0x%X ('%s') with modifiers 0x%X as a binding", keycode, keystr, modmask | ignored_mask);
+					return false;
+				}
+			}
+			
+			Gdk.error_trap_pop ();
+			
+			Logger.verbose ("Successfully bound key 0x%X ('%s') with modifiers 0x%X", keycode, keystr, modmask);
+			
+			// if this is a key-released binding then add corresponding modifiermask
+			// for keycode to our modmask if it is a modifier
+			if ((modmask & Gdk.ModifierType.RELEASE_MASK) == Gdk.ModifierType.RELEASE_MASK)
+				modmask |= get_modmask_for_keycode (keycode);
+			
+			// store binding
+			var binding = new Binding (accelerator, keycode, modmask, handler);
+			bindings.add (binding);
+			
+			return true;
+		}
+		
+		/**
+		 * Unbind given accelerator.
+		 *
+		 * @param accelerator accelerator parsable by Gtk.accelerator_parse
+		 */
+		public void unbind (string accelerator)
+		{
+			Logger.verbose ("Unbinding key " + accelerator);
+			
+			unowned X.Display display = Gdk.X11.get_default_xdisplay ();
+			var xid = Gdk.X11.get_default_root_xwindow ();
+			
+			// unbind all keys with given accelerator
+			var remove_bindings = new Gee.ArrayList<Binding> ();
+			foreach (var binding in bindings) {
+				if (str_equal (accelerator, binding.accelerator)) {
+					// if this is a key-released binding then remove corresponding modifiermask
+					// for keycode to our modmask if it is a modifier which we added on bind
+					if ((binding.modifiers & Gdk.ModifierType.RELEASE_MASK) == Gdk.ModifierType.RELEASE_MASK)
+						binding.modifiers &= ~get_modmask_for_keycode (binding.keycode);
+					
+					foreach (var ignored_mask in ignored_masks)
+						display.ungrab_key (binding.keycode, binding.modifiers | ignored_mask, xid);
+					remove_bindings.add (binding);
+				}
+			}
+			
+			// remove unbound keys
+			bindings.remove_all (remove_bindings);
+		}
+		
+		/**
+		 * Unbind all registered bindings.
+		 */
+		public void unbind_all ()
+		{
+			unowned X.Display display = Gdk.X11.get_default_xdisplay ();
+			var xid = Gdk.X11.get_default_root_xwindow ();
+			
+			// unbind all keys
+			foreach (var binding in bindings)
+				foreach (var ignored_mask in ignored_masks) {
+					// if this is a key-released binding then remove corresponding modifiermask
+					// for keycode to our modmask if it is a modifier which we added on bind
+					if ((binding.modifiers & Gdk.ModifierType.RELEASE_MASK) != 0)
+						binding.modifiers &= ~get_modmask_for_keycode (binding.keycode);
+					
+					display.ungrab_key (binding.keycode, binding.modifiers | ignored_mask, xid);
+				}
+			
+			bindings.clear ();
+		}
+		
+		/**
+		 * Event filter method needed to fetch X.Events
+		 */
+		[CCode (instance_pos = -1)]
+		Gdk.FilterReturn xevent_filter (Gdk.XEvent gdk_xevent, Gdk.Event gdk_event)
+		{
+			var filter_return = Gdk.FilterReturn.CONTINUE;
+			X.Event* xevent = (X.Event*) gdk_xevent;
+			
+			if (xevent->type != X.EventType.KeyPress && xevent->type != X.EventType.KeyRelease)
+				return filter_return;
+			
+			// remove NumLock, CapsLock and ScrollLock from key state
+			uint event_mods = (xevent->xkey.state & ~(ignored_masks[7]));
+			
+			foreach (var binding in bindings) {
+				if (xevent->xkey.keycode != binding.keycode)
+					continue;
+				
+				if ((xevent->type == X.EventType.KeyPress && (binding.modifiers == event_mods))
+					|| (xevent->type == X.EventType.KeyRelease
+					&& (binding.modifiers & Gdk.ModifierType.RELEASE_MASK) == Gdk.ModifierType.RELEASE_MASK
+					&& (binding.modifiers & ~Gdk.ModifierType.RELEASE_MASK) == event_mods)) {
+					
+					binding.handler (*xevent);
+					
+					// don't pass this event any futher
+					filter_return = Gdk.FilterReturn.REMOVE;
+				}
+			}
+			
+			return filter_return;
+		}
+		
+		/**
+		 * Convert the given accelerator to a modifier only accelerator.
+		 * This will convert the key to a modifier if possible and append it.
+		 *
+		 * @param accelerator accelerator parsable by Gtk.accelerator_parse
+		 */
+		public static string convert_to_modifier_only (string accelerator)
+		{
+			uint keysym;
+			Gdk.ModifierType modmask;
+			Gtk.accelerator_parse (accelerator, out keysym, out modmask);
+			
+			unowned X.Display display = Gdk.X11.get_default_xdisplay ();
+			uint8 keycode = display.keysym_to_keycode (keysym);
+			
+			if (keycode > 0)
+				modmask |= get_modmask_for_keycode (keycode);
+			
+			return get_accelerator_for_modmask (modmask);
+		}
+		
+		static string get_accelerator_for_modmask (Gdk.ModifierType modmask)
+		{
+			string result = "";
+			
+			if ((modmask & Gdk.ModifierType.CONTROL_MASK) == Gdk.ModifierType.CONTROL_MASK)
+				result += "<Ctrl>";
+			if ((modmask & Gdk.ModifierType.MOD1_MASK) == Gdk.ModifierType.MOD1_MASK)
+				result += "<Alt>";
+			if ((modmask & Gdk.ModifierType.SHIFT_MASK) == Gdk.ModifierType.SHIFT_MASK)
+				result += "<Shift>";
+			if ((modmask & Gdk.ModifierType.META_MASK) == Gdk.ModifierType.META_MASK)
+				result += "<AltGr>";
+			if ((modmask & Gdk.ModifierType.HYPER_MASK) == Gdk.ModifierType.HYPER_MASK)
+				result += "";
+			if (((modmask & Gdk.ModifierType.SUPER_MASK) == Gdk.ModifierType.SUPER_MASK
+				|| (modmask & Gdk.ModifierType.MOD4_MASK) == Gdk.ModifierType.MOD4_MASK))
+				result += "<Super>";
+			
+			return result;
+		}
+		
+		/**
+		 * Convert keycode to ModifierType if it is a modifier
+		 * otherwise return 0x0
+		 */
+		static Gdk.ModifierType get_modmask_for_keycode (uint keycode)
+		{
+			Gdk.ModifierType modmask;
+			
+			unowned X.Display display = Gdk.X11.get_default_xdisplay ();
+			var i = 0;
+			var keysym = display.keycode_to_keysym ((uint8)keycode, i);
+			
+			switch (keysym) {
+			case Gdk.Key.Control_L:
+			case Gdk.Key.Control_R:
+				modmask = Gdk.ModifierType.CONTROL_MASK;
+				break;
+			case Gdk.Key.Alt_L:
+			case Gdk.Key.Alt_R:
+				modmask = Gdk.ModifierType.MOD1_MASK;
+				break;
+			case Gdk.Key.Shift_L:
+			case Gdk.Key.Shift_R:
+				modmask = Gdk.ModifierType.SHIFT_MASK;
+				break;
+			case Gdk.Key.Meta_L:
+			case Gdk.Key.Meta_R:
+				modmask = Gdk.ModifierType.META_MASK;
+				break;
+			case Gdk.Key.Hyper_L:
+			case Gdk.Key.Hyper_R:
+				modmask = Gdk.ModifierType.HYPER_MASK;
+				break;
+			case Gdk.Key.Super_L:
+			case Gdk.Key.Super_R:
+				// FIXME somethings is wrong with the SUPER modifier between the GDK and X values
+				modmask = Gdk.ModifierType.MOD4_MASK; //Gdk.ModifierType.SUPER_MASK;
+				break;
+			default:
+				modmask = 0x0;
+				break;
+			}
+			
+			return modmask;
+		}
+	}
+}

=== modified file 'lib/Makefile.am'
--- lib/Makefile.am	2016-02-28 12:06:16 +0000
+++ lib/Makefile.am	2017-01-16 09:48:10 +0000
@@ -65,6 +65,7 @@
 	DockRenderer.vala \
 	DragManager.vala \
 	HideManager.vala \
+	KeybindingManager.vala \
 	PositionManager.vala \
 	DBus/Client.vala \
 	DBus/Interfaces.vala \

=== modified file 'lib/libplank.symbols'
--- lib/libplank.symbols	2016-04-10 09:00:49 +0000
+++ lib/libplank.symbols	2017-01-16 09:48:10 +0000
@@ -130,6 +130,7 @@
 plank_dock_controller_get_hide_manager
 plank_dock_controller_get_hover
 plank_dock_controller_get_Items
+plank_dock_controller_get_keybinding_manager
 plank_dock_controller_get_launchers_folder
 plank_dock_controller_get_name
 plank_dock_controller_get_position_manager
@@ -143,9 +144,11 @@
 plank_dock_controller_set_drag_manager
 plank_dock_controller_set_hide_manager
 plank_dock_controller_set_hover
+plank_dock_controller_set_keybinding_manager
 plank_dock_controller_set_position_manager
 plank_dock_controller_set_renderer
 plank_dock_controller_set_window
+plank_dock_controller_virtual_click_item_at
 plank_dock_element_accept_drop
 plank_dock_element_as_uri
 plank_dock_element_can_accept_drop
@@ -289,7 +292,10 @@
 plank_dock_preferences_get_HideDelay
 plank_dock_preferences_get_HideMode
 plank_dock_preferences_get_IconSize
+plank_dock_preferences_get_ItemAccelerator
+plank_dock_preferences_get_ItemOptionAccelerator
 plank_dock_preferences_get_ItemsAlignment
+plank_dock_preferences_get_KeybindingUnhideDelay
 plank_dock_preferences_get_LockItems
 plank_dock_preferences_get_Monitor
 plank_dock_preferences_get_Offset
@@ -313,7 +319,10 @@
 plank_dock_preferences_set_HideDelay
 plank_dock_preferences_set_HideMode
 plank_dock_preferences_set_IconSize
+plank_dock_preferences_set_ItemAccelerator
+plank_dock_preferences_set_ItemOptionAccelerator
 plank_dock_preferences_set_ItemsAlignment
+plank_dock_preferences_set_KeybindingUnhideDelay
 plank_dock_preferences_set_LockItems
 plank_dock_preferences_set_Monitor
 plank_dock_preferences_set_Offset
@@ -332,14 +341,19 @@
 plank_dock_renderer_get_local_cursor
 plank_dock_renderer_get_theme
 plank_dock_renderer_get_type
+plank_dock_renderer_get_VisibleKeybinding
 plank_dock_renderer_get_zoom_in_progress
+plank_dock_renderer_hide_keybindings
 plank_dock_renderer_initialize
 plank_dock_renderer_new
 plank_dock_renderer_reset_buffers
+plank_dock_renderer_set_VisibleKeybinding
+plank_dock_renderer_show_keybindings
 plank_dock_renderer_update_local_cursor
 plank_dock_theme_construct
 plank_dock_theme_create_background
 plank_dock_theme_create_indicator
+plank_dock_theme_create_keybinding
 plank_dock_theme_create_urgent_glow
 plank_dock_theme_draw_active_glow
 plank_dock_theme_draw_item_count
@@ -473,6 +487,15 @@
 plank_item_factory_make_element
 plank_item_factory_new
 plank_item_state_get_type
+plank_keybinding_get_type
+plank_keybinding_manager_bind
+plank_keybinding_manager_construct
+plank_keybinding_manager_convert_to_modifier_only
+plank_keybinding_manager_get_type
+plank_keybinding_manager_initialize
+plank_keybinding_manager_new
+plank_keybinding_manager_unbind
+plank_keybinding_manager_unbind_all
 plank_logger_get_DisplayLevel
 plank_logger_get_type
 plank_logger_initialize