Code review comment for lp:~docky-core/plank/indicator-style

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

> Theme naming:
> I'd vote for "flat" in case of a theme with the line type indicator and
> "modern" in case of the circle.

Let's see how this turns out when the styles are finished ;-)

> Looks:
> The circular ones look better if their center is in the middle of bottom
> padding: http://imgur.com/co1S0t7
> An extra slight bump off the ground instead might look better too.

I am not really convinced here.

> The circles also end up a bit too close together at times, depending on the
> size set (indicatorsize 1 looked to be too close, while 1.2 looked fine at
> icon size 48)
> http://imgur.com/sUCYEoN

Should be better now

> In my opinion lines should not indicate several instances being open, as it
> appears strange :D
> Neither chrome os nor windows seem to provide such information while having
> that kind of indicators. It feels as if the application were somehow divided
> into smaller fragments.

I agree here.

« Back to merge proposal