Docky

Merge lp:~docky-core/docky/battery-update into lp:docky

  1. battery-update
  2. Merge into trunk
Proposed by Rico Tzschichholz
Status: Merged
Merged at revision: 1704
Proposed branch: lp:~docky-core/docky/battery-update
Merge into: lp:docky
Diff against target: 0 lines
To merge this branch: bzr merge lp:~docky-core/docky/battery-update
Reviewer Review Type Date Requested Status
Rico Tzschichholz Approve
Robert Dyer (community) Abstain
Review via email: mp+37340@code.launchpad.net

Description of the change

Update BatteryDocklet

To post a comment you must log in.
Revision history for this message
Robert Dyer (psybers) wrote :

BatteryMonitorSysItem doesn't work

review: Disapprove
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Just wanted to see the diff and push you to fix it ;-)

Revision history for this message
Robert Dyer (psybers) wrote :

System.InvalidOperationException: Collection was modified;enumeration operation may not execute.
  at System.Collections.Generic.List`1+Enumerator[BatteryMonitor.BatteryMonitorUPowerItem+IUPowerDevice].MoveNext () [0x00000]
  at BatteryMonitor.BatteryMonitorUPowerItem.GetCurrentBatteryCapacity () [0x0009e] in /home/rdyer/branches/battery-update/StandardPlugins/BatteryMonitor/src/BatteryMonitorUPowerItem.cs:172
  at BatteryMonitor.BatteryMonitorAbstractItem.UpdateBattStat () [0x00015] in /home/rdyer/branches/battery-update/StandardPlugins/BatteryMonitor/src/BatteryMonitorAbstractItem.cs:94
  at GLib.Timeout+TimeoutProxy.Handler () [0x00000]
   at GLib.ExceptionManager.RaiseUnhandledException(System.Exception e, Boolean is_terminal)
   at GLib.Timeout+TimeoutProxy.Handler()
   at Gtk.Application.gtk_main()
   at Gtk.Application.Run()
   at Docky.Docky.Main(System.String[] args) in /home/rdyer/branches/battery-update/Docky/Docky/Docky.cs:line 95

Revision history for this message
Robert Dyer (psybers) wrote :

Fixed that crash with locks.

Revision history for this message
Robert Dyer (psybers) wrote :

Hit that bug again, using the new code.

System.InvalidOperationException: Collection was modified;enumeration operation may not execute.
  at System.Collections.Generic.List`1+Enumerator[BatteryMonitor.BatteryMonitorUPowerItem+IUPowerDevice].MoveNext () [0x00000]
  at BatteryMonitor.BatteryMonitorUPowerItem.GetCurrentBatteryCapacity () [0x00099] in /home/rdyer/branches/battery-update/StandardPlugins/BatteryMonitor/src/BatteryMonitorUPowerItem.cs:177
  at BatteryMonitor.BatteryMonitorAbstractItem.UpdateBattStat () [0x00015] in /home/rdyer/branches/battery-update/StandardPlugins/BatteryMonitor/src/BatteryMonitorAbstractItem.cs:94
  at GLib.Timeout+TimeoutProxy.Handler () [0x00000]
   at GLib.ExceptionManager.RaiseUnhandledException(System.Exception e, Boolean is_terminal)
   at GLib.Timeout+TimeoutProxy.Handler()
   at Gtk.Application.gtk_main()
   at Gtk.Application.Run()
   at Docky.Docky.Main(System.String[] args) in /home/rdyer/branches/battery-update/Docky/Docky/Docky.cs:line 95

Revision history for this message
Robert Dyer (psybers) wrote :

Rico/Chris: Review this please!

Revision history for this message
Robert Dyer (psybers) :
review: Abstain
Revision history for this message
Rico Tzschichholz (ricotz) :
review: Approve
lp:~docky-core/docky/battery-update updated
1643. By Robert Dyer

rename preferences to settings

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to status/vote changes: