Unity 8

Merge lp:~dobey/unity8/no-verify into lp:unity8

  1. no-verify
  2. Merge into trunk
Proposed by dobey
Status: Merged
Approved by: Charles Kerr
Approved revision: 1860
Merged at revision: 1917
Proposed branch: lp:~dobey/unity8/no-verify
Merge into: lp:unity8
Diff against target: 12 lines (+0/-2)
1 file modified
plugins/Ubuntu/Payments/Payments.cpp (+0/-2)
To merge this branch: bzr merge lp:~dobey/unity8/no-verify
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+265330@code.launchpad.net

Commit message

Do not call verify in the payments button code.

Description of the change

A regression test would probably be good here, but I'm not quite sure how to encode that into a unit test here. The issue is not 100% reproducible every time, and seems to happen only maybe 10-20% of the time, at least in my testing. With this branch, I was not able to recreate the issue even with testing the purchase/install/refund cycle about 25 times.

 * Are there any related MPs required for this MP to build/function as expected? Please list.

   No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?

   Yes, see description above.

 * Did you make sure that your branch does not contain spurious tags?

   No tags were added/removed in the branch.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

   N/A

 * If you changed the UI, has there been a design review?

   N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1860
http://jenkins.qa.ubuntu.com/job/unity8-ci/6093/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/401/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-wily/123
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-amd64-ci/331
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-i386-ci/332
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-wily-mako/293/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/401
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/401/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21995

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6093/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote :

Rodney/Charles can you please write the corresponding checklists?

https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/Ubuntu/Payments/Payments.cpp'
2--- plugins/Ubuntu/Payments/Payments.cpp 2014-09-18 13:50:52 +0000
3+++ plugins/Ubuntu/Payments/Payments.cpp 2015-07-20 21:27:52 +0000
4@@ -123,8 +123,6 @@
5 if (m_store_item_id.isEmpty()) {
6 return;
7 }
8-
9- pay_package_item_start_verification(m_package, m_store_item_id.toLocal8Bit().data());
10 }
11
12 void Payments::setPurchasing(bool is_purchasing)

Subscribers

People subscribed via source and target branches