Merge lp:~dobey/unity-scope-click/unsign-reviews into lp:unity-scope-click

Proposed by dobey
Status: Merged
Approved by: Charles Kerr
Approved revision: 434
Merged at revision: 434
Proposed branch: lp:~dobey/unity-scope-click/unsign-reviews
Merge into: lp:unity-scope-click
Diff against target: 31 lines (+4/-3)
2 files modified
libclickscope/click/reviews.cpp (+2/-1)
libclickscope/tests/test_reviews.cpp (+2/-2)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/unsign-reviews
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+290117@code.launchpad.net

Commit message

Must not sign the call to get the existing reviews for a package.

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libclickscope/click/reviews.cpp'
2--- libclickscope/click/reviews.cpp 2016-01-27 18:25:47 +0000
3+++ libclickscope/click/reviews.cpp 2016-03-25 14:11:50 +0000
4@@ -131,7 +131,8 @@
5 click::web::CallParams params;
6 params.add(click::REVIEWS_QUERY_ARGNAME, package_name.c_str());
7 QSharedPointer<click::web::Response> response = client->call
8- (get_base_url() + click::REVIEWS_API_PATH, params);
9+ (get_base_url() + click::REVIEWS_API_PATH, "GET", false,
10+ std::map<std::string, std::string>{}, "", params);
11
12 QObject::connect(response.data(), &click::web::Response::finished,
13 [=](QString reply) {
14
15=== modified file 'libclickscope/tests/test_reviews.cpp'
16--- libclickscope/tests/test_reviews.cpp 2016-02-29 21:08:09 +0000
17+++ libclickscope/tests/test_reviews.cpp 2016-03-25 14:11:50 +0000
18@@ -150,12 +150,12 @@
19 click::Reviews::Error) {});
20 }
21
22-TEST_F(ReviewsTest, testFetchReviewsSignsCall)
23+TEST_F(ReviewsTest, testFetchReviewsDoesNotSignCall)
24 {
25 LifetimeHelper<click::network::Reply, MockNetworkReply> reply;
26 auto response = responseForReply(reply.asSharedPtr());
27
28- EXPECT_CALL(*clientPtr, callImpl(_, _, true, _, _, _))
29+ EXPECT_CALL(*clientPtr, callImpl(_, _, false, _, _, _))
30 .Times(1)
31 .WillOnce(Return(response));
32

Subscribers

People subscribed via source and target branches

to all changes: