Merge lp:~dobey/unity-scope-click/show-publisher into lp:unity-scope-click/devel

Proposed by dobey
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 223
Merged at revision: 225
Proposed branch: lp:~dobey/unity-scope-click/show-publisher
Merge into: lp:unity-scope-click/devel
Diff against target: 18 lines (+2/-5)
1 file modified
scope/click/preview.cpp (+2/-5)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/show-publisher
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+217482@code.launchpad.net

Commit message

Display the publisher in the header, not the first line of description.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scope/click/preview.cpp'
2--- scope/click/preview.cpp 2014-04-25 18:38:01 +0000
3+++ scope/click/preview.cpp 2014-04-28 17:46:20 +0000
4@@ -143,12 +143,9 @@
5
6 scopes::PreviewWidget header("hdr", "header");
7 header.add_attribute_value("title", scopes::Variant(details.package.title));
8- if (!details.description.empty())
9+ if (!details.publisher.empty())
10 {
11- std::stringstream ss(details.description);
12- std::string first_line;
13- if (std::getline(ss, first_line))
14- header.add_attribute_value("subtitle", scopes::Variant(first_line));
15+ header.add_attribute_value("subtitle", scopes::Variant(details.publisher));
16 }
17 if (!details.package.icon_url.empty())
18 header.add_attribute_value("mascot", scopes::Variant(details.package.icon_url));

Subscribers

People subscribed via source and target branches

to all changes: