Merge lp:~dobey/unity-scope-click/no-no-internet into lp:unity-scope-click/devel

Proposed by dobey
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 315
Merged at revision: 321
Proposed branch: lp:~dobey/unity-scope-click/no-no-internet
Merge into: lp:unity-scope-click/devel
Diff against target: 19 lines (+0/-10)
1 file modified
scope/clickstore/store-query.cpp (+0/-10)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/no-no-internet
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Paweł Stołowski (community) Approve
Review via email: mp+226321@code.launchpad.net

Commit message

Drop the no-internet setting check, as store requires explicit search now.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Yeah, makes sense. +1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scope/clickstore/store-query.cpp'
2--- scope/clickstore/store-query.cpp 2014-06-26 18:07:51 +0000
3+++ scope/clickstore/store-query.cpp 2014-07-10 15:30:26 +0000
4@@ -433,15 +433,5 @@
5 categoryTemplate = CATEGORY_APPS_DISPLAY;
6 }
7
8- static const std::string no_net_hint("no-internet");
9- if (impl->meta.contains_hint(no_net_hint))
10- {
11- auto var = impl->meta[no_net_hint];
12- if (var.which() == scopes::Variant::Type::Bool && var.get_bool())
13- {
14- return;
15- }
16- }
17-
18 add_available_apps(searchReply, get_installed_packages(), categoryTemplate);
19 }

Subscribers

People subscribed via source and target branches

to all changes: