Merge lp:~dobey/unity-scope-click/merge-trunk into lp:unity-scope-click/devel

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: no longer in the source branch.
Merged at revision: 288
Proposed branch: lp:~dobey/unity-scope-click/merge-trunk
Merge into: lp:unity-scope-click/devel
Diff against target: 67 lines (+19/-19)
3 files modified
debian/changelog (+19/-0)
scope/clickapps/apps-scope.cpp (+0/-9)
scope/clickstore/store-scope.cpp (+0/-10)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/merge-trunk
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alejandro J. Cura (community) Approve
Review via email: mp+222951@code.launchpad.net

Commit message

Remove unused method to fix failure building under gcc 4.9.

To post a comment you must log in.
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
288. By dobey

Remove unused method to fix failure building under gcc 4.9.

Approved by PS Jenkins bot, Alejandro J. Cura.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-05-20 14:57:40 +0000
3+++ debian/changelog 2014-06-12 14:26:55 +0000
4@@ -1,3 +1,22 @@
5+unity-scope-click (0.1+14.10.20140611-0ubuntu1) utopic; urgency=low
6+
7+ [ Rodney Dawes ]
8+ * Remove unused method to fix failure building under gcc 4.9.
9+
10+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Wed, 11 Jun 2014 16:50:57 +0000
11+
12+unity-scope-click (0.1+14.10.20140523-0ubuntu1) utopic; urgency=low
13+
14+ [ Rodney Dawes ]
15+ * Handle some languages differently when submitting reviews. (LP:
16+ #1321154). Add runtime dependency on ubuntu-sdk-libs for the
17+ frameworks list. (LP: #1320975). Support hal+json in the search
18+ request. Fix issues in autopilot tests. Port autopilot tests to
19+ python3. Add README and HACKING files. (LP: #1226111). Translations
20+ updates. . (LP: #1321154, #1226111, #1320975)
21+
22+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Fri, 23 May 2014 15:00:36 +0000
23+
24 unity-scope-click (0.1+14.10.20140520-0ubuntu1) utopic; urgency=low
25
26 [ Rodney Dawes ]
27
28=== modified file 'scope/clickapps/apps-scope.cpp'
29--- scope/clickapps/apps-scope.cpp 2014-05-28 07:42:24 +0000
30+++ scope/clickapps/apps-scope.cpp 2014-06-12 14:26:55 +0000
31@@ -42,15 +42,6 @@
32 #include "apps-scope.h"
33 #include "apps-query.h"
34
35-namespace
36-{
37-click::Interface& clickInterfaceInstance()
38-{
39- static QSharedPointer<click::KeyFileLocator> keyFileLocator(new click::KeyFileLocator());
40- static click::Interface iface(keyFileLocator);
41- return iface;
42-}
43-}
44
45 click::Scope::Scope()
46 {
47
48=== modified file 'scope/clickstore/store-scope.cpp'
49--- scope/clickstore/store-scope.cpp 2014-06-03 13:52:16 +0000
50+++ scope/clickstore/store-scope.cpp 2014-06-12 14:26:55 +0000
51@@ -43,16 +43,6 @@
52 #include <logging.h>
53
54
55-namespace
56-{
57-click::Interface& clickInterfaceInstance()
58-{
59- static QSharedPointer<click::KeyFileLocator> keyFileLocator(new click::KeyFileLocator());
60- static click::Interface iface(keyFileLocator);
61- return iface;
62-}
63-}
64-
65 click::Scope::Scope()
66 {
67 nam.reset(new click::network::AccessManager());

Subscribers

People subscribed via source and target branches

to all changes: