Merge lp:~dobey/unity-scope-click/log-logic-exc into lp:unity-scope-click/touch-15-04

Proposed by dobey
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 325
Merged at revision: 325
Proposed branch: lp:~dobey/unity-scope-click/log-logic-exc
Merge into: lp:unity-scope-click/touch-15-04
Diff against target: 31 lines (+16/-0)
2 files modified
libclickscope/click/key_file_locator.cpp (+2/-0)
libclickscope/tests/applications/user/pre-translated.desktop (+14/-0)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/log-logic-exc
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
Review via email: mp+264847@code.launchpad.net

Commit message

Log logic exceptions as critical to avoid failing on incorrect .desktop files.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libclickscope/click/key_file_locator.cpp'
2--- libclickscope/click/key_file_locator.cpp 2014-05-13 19:32:29 +0000
3+++ libclickscope/click/key_file_locator.cpp 2015-07-15 14:05:18 +0000
4@@ -56,6 +56,8 @@
5 filename.toUtf8().data());
6 } catch (const unity::FileException& file_exp) {
7 qWarning() << "Error reading file:" << file_exp.to_string().c_str();
8+ } catch (const unity::LogicException& logic_exp) {
9+ qCritical() << "Error reading file:" << logic_exp.to_string().c_str();
10 }
11 }
12 }
13
14=== added file 'libclickscope/tests/applications/user/pre-translated.desktop'
15--- libclickscope/tests/applications/user/pre-translated.desktop 1970-01-01 00:00:00 +0000
16+++ libclickscope/tests/applications/user/pre-translated.desktop 2015-07-15 14:05:18 +0000
17@@ -0,0 +1,14 @@
18+[Desktop Entry]
19+Version=1.0
20+Type=Application
21+Terminal=false
22+Exec=aa-exec-click -p com.ubuntu.clock_clock_1.0.300 -- qmlscene ./ubuntu-clock-app.qml
23+Icon=/usr/share/click/preinstalled/.click/users/@all/com.ubuntu.clock/./clock64.png
24+_Name=Untranslated Clock
25+X-Ubuntu-Touch=true
26+X-Ubuntu-StageHint=SideStage
27+X-Ubuntu-Gettext-Domain=com.ubuntu.clock
28+
29+Path=/usr/share/click/preinstalled/.click/users/@all/com.ubuntu.clock
30+X-Ubuntu-Old-Icon=./clock64.png
31+X-Ubuntu-Application-ID=com.ubuntu.clock_clock_1.0.300

Subscribers

People subscribed via source and target branches

to all changes: