unity-scope-click

Merge lp:~dobey/unity-scope-click/fix-purchase-preview-tst into lp:unity-scope-click

  1. fix-purchase-preview-tst
  2. Merge into trunk
Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 96
Merged at revision: 96
Proposed branch: lp:~dobey/unity-scope-click/fix-purchase-preview-tst
Merge into: lp:unity-scope-click
Diff against target: 11 lines (+1/-0)
1 file modified
src/test-click-webservice.vala (+1/-0)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/fix-purchase-preview-tst
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Mike McCracken (community) Approve
Review via email: mp+199710@code.launchpad.net

Commit message

Replace the webservice object on the scope to avoid network access.

Description of the change

Without this change, "make G_MESSAGES_DEUBG=all check" will show a debug message about a 404 from the server for the test_build_purchasing_preview test. With the change, there will be no debug message from that test.

To post a comment you must log in.
Revision history for this message
Mike McCracken (mikemc) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:96
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/135/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-armhf-ci/33

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/135/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/test-click-webservice.vala'
2--- src/test-click-webservice.vala 2013-12-19 18:16:05 +0000
3+++ src/test-click-webservice.vala 2013-12-19 20:00:48 +0000
4@@ -393,6 +393,7 @@
5 {
6 MainLoop mainloop = new MainLoop ();
7 ClickScope scope = new ClickScope ();
8+ scope.webservice = new FakeClickWebservice ();
9 var metadata = new HashTable<string, Variant> (str_hash, str_equal);
10 metadata.insert(METADATA_APP_ID, new GLib.Variant.string(FAKE_APP_ID));
11 var fake_result = Unity.ScopeResult.create("", "", 0,

Subscribers

People subscribed via source and target branches

to all changes: