Merge lp:~dobey/unity-scope-click/fallback-app-icon into lp:unity-scope-click

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 396
Merged at revision: 399
Proposed branch: lp:~dobey/unity-scope-click/fallback-app-icon
Merge into: lp:unity-scope-click
Diff against target: 71 lines (+12/-7)
2 files modified
scope/clickapps/apps-query.cpp (+3/-2)
scope/clickstore/store-query.cpp (+9/-5)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/fallback-app-icon
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+278876@code.launchpad.net

Commit message

Add the fallback attribute to the result components.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scope/clickapps/apps-query.cpp'
2--- scope/clickapps/apps-query.cpp 2015-11-24 18:23:23 +0000
3+++ scope/clickapps/apps-query.cpp 2016-01-06 18:08:53 +0000
4@@ -1,5 +1,5 @@
5 /*
6- * Copyright (C) 2014 Canonical Ltd.
7+ * Copyright (C) 2014-2015 Canonical Ltd.
8 *
9 * This program is free software: you can redistribute it and/or modify it
10 * under the terms of the GNU General Public License version 3, as published
11@@ -62,7 +62,8 @@
12 "art" : {
13 "field": "art",
14 "aspect-ratio": 1.6,
15- "fill-mode": "fit"
16+ "fill-mode": "fit",
17+ "fallback": "image://theme/placeholder-app-icon"
18 }
19 }
20 }
21
22=== modified file 'scope/clickstore/store-query.cpp'
23--- scope/clickstore/store-query.cpp 2015-11-24 18:23:23 +0000
24+++ scope/clickstore/store-query.cpp 2016-01-06 18:08:53 +0000
25@@ -1,5 +1,5 @@
26 /*
27- * Copyright (C) 2014 Canonical Ltd.
28+ * Copyright (C) 2014-2015 Canonical Ltd.
29 *
30 * This program is free software: you can redistribute it and/or modify it
31 * under the terms of the GNU General Public License version 3, as published
32@@ -76,7 +76,8 @@
33 "attributes": { "field": "attributes", "max-count": 4 },
34 "art" : {
35 "field": "art",
36- "aspect-ratio": 1.13
37+ "aspect-ratio": 1.13,
38+ "fallback": "image://theme/placeholder-app-icon"
39 }
40 }
41 }
42@@ -95,7 +96,8 @@
43 "attributes": { "field": "attributes", "max-count": 1 },
44 "art" : {
45 "field": "art",
46- "aspect-ratio": 0.55
47+ "aspect-ratio": 0.55,
48+ "fallback": "image://theme/placeholder-app-icon"
49 }
50 }
51 }
52@@ -114,7 +116,8 @@
53 "attributes": { "field": "attributes", "max-count": 4 },
54 "art": {
55 "aspect-ratio": 2.5,
56- "field": "art"
57+ "field": "art",
58+ "fallback": "image://theme/placeholder-app-icon"
59 }
60 }
61 })";
62@@ -132,7 +135,8 @@
63 "title" : "title",
64 "art" : {
65 "field": "art",
66- "aspect-ratio": 1.13
67+ "aspect-ratio": 1.13,
68+ "fallback": "image://theme/placeholder-app-icon"
69 },
70 "subtitle": "subtitle",
71 "attributes": { "field": "attributes", "max-count": 3 }

Subscribers

People subscribed via source and target branches

to all changes: