unity-scope-click

Merge lp:~dobey/unity-scope-click/enable-submit-reviews into lp:unity-scope-click/devel

  1. enable-submit-reviews
  2. Merge into devel
Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 244
Merged at revision: 246
Proposed branch: lp:~dobey/unity-scope-click/enable-submit-reviews
Merge into: lp:unity-scope-click/devel
Diff against target: 25 lines (+2/-3)
2 files modified
scope/click/preview.cpp (+1/-2)
scope/click/reviews.cpp (+1/-1)
To merge this branch: bzr merge lp:~dobey/unity-scope-click/enable-submit-reviews
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alejandro J. Cura (community) Approve
Review via email: mp+218849@code.launchpad.net

Commit message

Re-enable submission of reviews from the installed preview.
Use "Review" as the summary as empty string is not allowed.

To post a comment you must log in.
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Looks good

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scope/click/preview.cpp'
2--- scope/click/preview.cpp 2014-05-02 15:55:02 +0000
3+++ scope/click/preview.cpp 2014-05-08 17:07:20 +0000
4@@ -470,8 +470,7 @@
5 reply->push(createButtons(uri, removable));
6 reply->push(descriptionWidgets(details));
7
8- // Hide the rating widget until #1314117 is fixed.
9- if (false && review.rating == 0 && removable) {
10+ if (review.rating == 0 && removable) {
11 scopes::PreviewWidgetList review_input;
12 scopes::PreviewWidget rating("rating", "rating-input");
13 rating.add_attribute_value("required", scopes::Variant("rating"));
14
15=== modified file 'scope/click/reviews.cpp'
16--- scope/click/reviews.cpp 2014-04-29 02:44:28 +0000
17+++ scope/click/reviews.cpp 2014-05-08 17:07:20 +0000
18@@ -143,7 +143,7 @@
19 root["language"] = click::Configuration().get_language_base();
20
21 // NOTE: "summary" is a required field, but we don't have one. Use "".
22- root["summary"] = "";
23+ root["summary"] = "Review";
24
25 qDebug() << "Rating" << review.package_name.c_str() << review.rating;
26

Subscribers

People subscribed via source and target branches

to all changes: