Merge lp:~dobey/unity-scope-click/cn-depts into lp:unity-scope-click

Proposed by dobey
Status: Merged
Approved by: Ted Gould
Approved revision: 462
Merged at revision: 462
Proposed branch: lp:~dobey/unity-scope-click/cn-depts
Merge into: lp:unity-scope-click
Diff against target: 2 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~dobey/unity-scope-click/cn-depts
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Needs Fixing
Ted Gould (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+298171@code.launchpad.net

Commit message

Update departments.db with Chinese translations.

Description of the change

Since it's a binary file, a quick way to check this is to run: sqlite3 data/departments.db "select * from deptnames;"

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

Shocked to see these in a binary file in the VCS. But that's not what this MR is about, so it's fine. I can see the Chinese translations.

review: Approve
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Note, this will only help new phone users (or if you flash & wipe local data). Existing users will still not see Chinese departments in Apps scope *until* they go to Store scope (after that the Store will update the database for them, making them available for Apps scope). This is because the default departments.db that you modified is only used to initialize ~/.cache/click-departments.db if it doesn't exist yet, so in fact only on first boot (see data/click-scope-departments-db.conf.in for the relevant script).

To handle upgrades you will need to update data/update_schema.sh and bump schema version in DepartmentsDb::init_db().

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/departments.db'
2Binary files data/departments.db 2015-01-23 01:37:54 +0000 and data/departments.db 2016-06-22 20:51:38 +0000 differ

Subscribers

People subscribed via source and target branches

to all changes: