Merge lp:~dobey/ubuntuone-storage-protocol/update-13-10 into lp:ubuntuone-storage-protocol/stable-13-10

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 161
Merged at revision: 161
Proposed branch: lp:~dobey/ubuntuone-storage-protocol/update-13-10
Merge into: lp:ubuntuone-storage-protocol/stable-13-10
Diff against target: 18 lines (+3/-3)
1 file modified
ubuntuone/storageprotocol/request.py (+3/-3)
To merge this branch: bzr merge lp:~dobey/ubuntuone-storage-protocol/update-13-10
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+178758@code.launchpad.net

Commit message

[Rodney Dawes]

    Fix a typo (ensure vs assure).
    Change the example-in-docstring to not look like a doctest.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/ubuntuone-storage-protocol/update-13-10 into lp:ubuntuone-storage-protocol/stable-13-10 failed. Below is the output from the failed tests.

running build

*** Cannot find protoc; is the protobuf-compiler package installed?

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/ubuntuone-storage-protocol/update-13-10 into lp:ubuntuone-storage-protocol/stable-13-10 failed. Below is the output from the failed tests.

running build

*** Cannot find protoc; is the protobuf-compiler package installed?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/storageprotocol/request.py'
2--- ubuntuone/storageprotocol/request.py 2013-05-21 17:22:58 +0000
3+++ ubuntuone/storageprotocol/request.py 2013-08-06 13:58:41 +0000
4@@ -441,11 +441,11 @@
5 def cancel_filter(self, function):
6 """Raises RequestCancelledError if the request is cancelled.
7
8- This methods exists to be used in a addCallback sequence to assure
9+ This methods exists to be used in a addCallback sequence to ensure
10 that it does not continue if the request is cancelled, like:
11
12- >>> d.addCallback(cancel_filter(foo))
13- >>> d.addCallbacks(done_callback, error_errback)
14+ d.addCallback(cancel_filter(foo))
15+ d.addCallbacks(done_callback, error_errback)
16
17 Note that you may receive RequestCancelledError in your
18 'error_errback' func.

Subscribers

People subscribed via source and target branches

to all changes: