ubuntuone-installer

Merge lp:~dobey/ubuntuone-installer/string-change into lp:ubuntuone-installer

  1. string-change
  2. Merge into trunk
Proposed by dobey on 2012-03-06
Status: Rejected
Rejected by: dobey on 2012-03-06
Proposed branch: lp:~dobey/ubuntuone-installer/string-change
Merge into: lp:ubuntuone-installer
Diff against target: 21 lines (+2/-2)
1 file modified
ubuntuone/installer/gui.py (+2/-2)
To merge this branch: bzr merge lp:~dobey/ubuntuone-installer/string-change
Reviewer Review Type Date Requested Status
dobey (community) Disapprove on 2012-03-06
Natalia Bidart 2012-03-06 Approve on 2012-03-06
Review via email: mp+96037@code.launchpad.net

Commit Message

Change the sync marketing string per design request

To post a comment you must log in.
Natalia Bidart (nataliabidart) wrote :

You also need to change

ubuntuone/installer/gui.py:111: _(u'Discover the freedom of your personal cloud')

to be:

ubuntuone/installer/gui.py:111: _(u'Discover your personal cloud')

Thanks!

review: Needs Fixing
lp:~dobey/ubuntuone-installer/string-change updated on 2012-03-06
26. By dobey on 2012-03-06

Change the other string too

Natalia Bidart (nataliabidart) wrote :

Looks good.

review: Approve
dobey (dobey) wrote :

Apparently the layout and image also need changed. :(

review: Disapprove

Unmerged revisions

26. By dobey on 2012-03-06

Change the other string too

25. By dobey on 2012-03-06

Change the sync marketing string per design request

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/installer/gui.py'
2--- ubuntuone/installer/gui.py 2012-02-24 18:06:28 +0000
3+++ ubuntuone/installer/gui.py 2012-03-06 13:59:33 +0000
4@@ -108,7 +108,7 @@
5 self.__hlabel.show()
6
7 self.__hlabel2 = Gtk.Label((u'<span size="large">{}</span>').format(
8- _(u'Discover the freedom of your personal cloud')))
9+ _(u'Discover your personal cloud')))
10 self.__hlabel2.set_use_markup(True)
11 self.__hlabel2.set_alignment(0.0, 0.0)
12 self.__hlabelbox.pack_start(self.__hlabel2, False, False, 0)
13@@ -255,7 +255,7 @@
14 width_chars = (image.get_pixbuf().get_width() / width) * 2.5
15
16 label = Gtk.Label(u'<small>{}</small>'.format(
17- _(u'Sync files across your devices.')))
18+ _(u'Upload your files and see them on any device.')))
19 label.set_max_width_chars(width_chars)
20 label.set_width_chars(width_chars)
21 label.set_use_markup(True)

Subscribers

People subscribed via source and target branches

to all changes: