Code review comment for lp:~dobey/ubuntuone-installer/new-logo

Revision history for this message
Manuel de la Peña (mandel) wrote :

Can we have some tests added for this, I'm not that concern about adding tests for the spacing (that is just stupid) but I'd like to see at least a test asserting that the correct logo is used.

Also AFAIK the data/u1logo.svg is not present in the, is that intentional? I thin that we should ensure that if a user uses the all the required data is copied.

review: Needs Fixing

« Back to merge proposal