Merge lp:~dobey/ubuntuone-dev-tools/twisted-ankle into lp:ubuntuone-dev-tools

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 105
Merged at revision: 105
Proposed branch: lp:~dobey/ubuntuone-dev-tools/twisted-ankle
Merge into: lp:ubuntuone-dev-tools
Diff against target: 27 lines (+4/-4)
1 file modified
ubuntuone/devtools/runners/__init__.py (+4/-4)
To merge this branch: bzr merge lp:~dobey/ubuntuone-dev-tools/twisted-ankle
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+173572@code.launchpad.net

Commit message

Don't set the tests container variable as a set or list, for now.
Use the appropriate set updating or list extending method for compat.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/devtools/runners/__init__.py'
2--- ubuntuone/devtools/runners/__init__.py 2012-11-28 21:45:47 +0000
3+++ ubuntuone/devtools/runners/__init__.py 2013-07-08 18:55:45 +0000
4@@ -203,7 +203,6 @@
5
6 def __init__(self, *args, **kwargs):
7 super(BaseTestOptions, self).__init__(*args, **kwargs)
8- self['tests'] = set()
9
10 def opt_help_runners(self):
11 """List the runners which are supported."""
12@@ -239,11 +238,12 @@
13 self['test'] = option
14
15 # We use some camelcase names for trial compatibility here.
16- # pylint: disable=C0103
17 def parseArgs(self, *args):
18 """Handle the extra arguments."""
19- self['tests'].update(args)
20- # pylint: enable=C0103
21+ if isinstance(self.tests, set):
22+ self['tests'].update(args)
23+ elif isinstance(self.tests, list):
24+ self['tests'].extend(args)
25
26
27 def _get_runner_options(runner_name):

Subscribers

People subscribed via source and target branches

to all changes: