ubuntuone-dev-tools

Merge lp:~dobey/ubuntuone-dev-tools/fix-689851 into lp:ubuntuone-dev-tools

  1. fix-689851
  2. Merge into trunk
Proposed by dobey on 2010-12-13
Status: Merged
Approved by: Stuart Colville on 2010-12-15
Approved revision: 14
Merged at revision: 14
Proposed branch: lp:~dobey/ubuntuone-dev-tools/fix-689851
Merge into: lp:ubuntuone-dev-tools
Diff against target: 13 lines (+3/-1)
1 file modified
bin/u1trial (+3/-1)
To merge this branch: bzr merge lp:~dobey/ubuntuone-dev-tools/fix-689851
Reviewer Review Type Date Requested Status
Stuart Colville (community) 2010-12-13 Approve on 2010-12-15
Natalia Bidart 2010-12-13 Approve on 2010-12-13
Review via email: mp+43571@code.launchpad.net

Commit Message

Iterate through the required services and only append if not already in the list, rather than doing list.extend()

To post a comment you must log in.
Natalia Bidart (nataliabidart) :
review: Approve
Stuart Colville (muffinresearch) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/u1trial'
2--- bin/u1trial 2010-11-22 18:57:18 +0000
3+++ bin/u1trial 2010-12-13 20:39:25 +0000
4@@ -74,7 +74,9 @@
5 for member_type in members:
6 if hasattr(member_type, 'required_services'):
7 member = member_type()
8- self.required_services.extend(member.required_services())
9+ for service in member.required_services():
10+ if service not in self.required_services:
11+ self.required_services.append(service)
12 del member
13 gc.collect()
14

Subscribers

People subscribed via source and target branches

to all changes: