Merge lp:~dobey/ubuntuone-credentials/qtinfo-fix into lp:ubuntuone-credentials

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 221
Merged at revision: 220
Proposed branch: lp:~dobey/ubuntuone-credentials/qtinfo-fix
Merge into: lp:ubuntuone-credentials
Diff against target: 23 lines (+6/-0)
1 file modified
libubuntuoneauth/logging.cpp (+6/-0)
To merge this branch: bzr merge lp:~dobey/ubuntuone-credentials/qtinfo-fix
Reviewer Review Type Date Requested Status
Kyle Fazzari (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+279289@code.launchpad.net

Commit message

Handle the new QtInfoMsg type when compiling against Qt >= 5.5.

To post a comment you must log in.
221. By dobey

Do the version check correctly.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libubuntuoneauth/logging.cpp'
2--- libubuntuoneauth/logging.cpp 2014-08-01 15:09:37 +0000
3+++ libubuntuoneauth/logging.cpp 2015-12-02 15:38:58 +0000
4@@ -18,6 +18,7 @@
5 #include <QDateTime>
6 #include <QDir>
7 #include <QStandardPaths>
8+#include <QtGlobal>
9
10 #include "logging.h"
11
12@@ -92,6 +93,11 @@
13 case QtFatalMsg:
14 return QStringLiteral("FATAL");
15 break;
16+#if QT_VERSION >= QT_VERSION_CHECK(5, 5, 0)
17+ case QtInfoMsg:
18+ return QStringLiteral("INFO");
19+ break;
20+#endif
21 }
22 return QStringLiteral("UNKNOWN");
23 }

Subscribers

People subscribed via source and target branches

to all changes: